[DO NOT MERGE] Debug changes #19530
Draft
[DO NOT MERGE] Debug changes #19530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make the cache presence unconditional by looking them up at runtime as a fallback. This consolidates the if branches into one and saves us a couple of map lookups with old applications. - Switch to eager initialization of cache entries. - Add cleanup of cache instances when unloading a library.
Most of the unit test kernels don't have any arguments, and those that do typically use a single accessor. Prior to this change, kernel size was passed as a template parameter of the kernel function type, while still sharing the same kernel name. This causes problems for the upcoming change to kernel name based caches, which will be tied to both types and strings. Since currently there are only 2 cases for such test kernels: no arguments and a single accessor, this patch simply adds a separate kernel for the latter case.
This reverts commit a91c7a9.
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.