[SYCL] Free function kernels bugfix #19535
Open
+158
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When free function kernel is a function template which in turn has arguments that are also templates, we may not print the latter properly into integration header. Specifically, if an argument of a templated free function kernel has an `enum` template argument of its own then namespace qualifiers for it will be missing. This patch fixed that.
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
commented
Jul 21, 2025
| void templated_on_B(ns::nested::feature_B<T, V> Arg) {} | ||
| template void templated_on_B(ns::nested::feature_B<int, 12>); | ||
|
|
||
| // CHECK: template <typename T, int V> void templated_on_B(ns::nested::feature_B<T, V, ns::nested::enum_B::A, ns::enum_A::C>); |
There was a problem hiding this comment.
Note for reviewers: the exact thing which was missing is ns::nested:: for enum_B::A and ns:: for enum_A::C.
AlexeySachkov
commented
Jul 21, 2025
| @@ -267,17 +267,17 @@ namespace Testing::Tests { | |||
| // CHECK-NEXT: return (void (*)(struct ns::Arg<class ns::ns1::hasDefaultArg<struct ns::notatuple>, int, 12, struct ns::notatuple>))simple1; | |||
| // CHECK-NEXT: } | |||
|
|
|||
| // CHECK: template <typename T> void templated(ns::Arg<T, float, 3, ns::notatuple> , T end); | |||
| // CHECK: template <typename T> void templated(ns::Arg<T, float, 3, ns::notatuple, <>>, T); | |||
There was a problem hiding this comment.
Two changes here:
- names of arguments in forward-declarations were dropped intentionally, because that's unnecessary information
<>is the way how empty type packs are printed. I'm not 100% sure that this is a legal C++ code, but I checked that generated integration header compiles with clang
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@AlexeySachkov Would you mind as well removing explicit accessor parameters from this test to check if it works with defaults ? |
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Thanks for the pointer. I've expanded E2E testing in 414cb2a |
dyniols
approved these changes
Jul 24, 2025
dklochkov-emb
approved these changes
Jul 24, 2025
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lbushi25
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When free function kernel is a function template which in turn has arguments that are also templates, we may not print the latter properly into integration header.
Specifically, if an argument of a templated free function kernel has an
enumtemplate argument of its own then namespace qualifiers for it will be missing.This patch fixed that.