[NFC][SYCL] Better "managed" ur_program_handle_t
#19536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was `ProgramManager::ProgramPtr` alias over `std::unique_ptr` with a custom deleter to RAII-manage `ur_program_handle_t` lifetime but it was applied in just a few places with the rest of the usage left with C-style explicit management. This PR introduce a dedicated helper class to manage all UR handle types that I think is more convenient than `ProgramManager::ProgramPtr`. I'm also switching all the objects that stored `ur_program_handle_t` and then `urProgramRelease`d them to use that new helper, while leaving the full refactoring (i.e., create those `Managed` objects at `urProgramCreate*`/`urProgramRetain` point) to a subsequent PRs to ease review process. Other `ur*_handle_t`s are left to subsequent changes as well.
aelovikov-intel
force-pushed
the
managed_ur_program
branch
from
527211b to
886a68a
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
againull
approved these changes
Jul 21, 2025
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
force-pushed
the
managed_ur_program
branch
from
653fcf6 to
7bd44b7
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Latest update was non-trivial, so another round of review is necessary. |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
approved these changes
Jul 21, 2025
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jul 23, 2025
Similar to what's been done with `ur_program_handle_t` in intel#19536 intel#19557
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jul 24, 2025
Similar to what's been done with `ur_program_handle_t` in intel#19536 intel#19557
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jul 24, 2025
Similar to what's been done with `ur_program_handle_t` in intel#19536 intel#19557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was
ProgramManager::ProgramPtralias overstd::unique_ptrwith a custom deleter to RAII-manageur_program_handle_tlifetime but it was applied in just a few places with the rest of the usage left with C-style explicit management.This PR introduce a dedicated helper class to manage all UR handle types that I think is more convenient than
ProgramManager::ProgramPtr. I'm also switching all the objects that storedur_program_handle_tand thenurProgramReleased them to use that new helper, while leaving the full refactoring (i.e., create thoseManagedobjects aturProgramCreate*/urProgramRetainpoint) to a subsequent PRs to ease review process.Other
ur*_handle_ts are left to subsequent changes as well.