[NFCI][SYCL] Keep raw ptr/ref to devices/platforms in context_impl
#19629
+71
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to intel#19613. Refactoring has started in intel#18143 intel#18251 This didn't work back then due to some unittests failing (because `global_handler` shutdown is different with unittests) but it doesn't seem to be an issue any more, probably due to other refactoring PRs that prefer raw ptr/refs over `std::shared_ptr` elsewhere.
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
commented
Jul 31, 2025
| @@ -15,8 +15,15 @@ inline namespace _V1 { | |||
| namespace ext::oneapi::experimental::this_thread { | |||
|
|
|||
| namespace detail { | |||
| inline sycl::device &get_current_device_ref() { | |||
| static thread_local sycl::device current_device{sycl::default_selector_v}; | |||
There was a problem hiding this comment.
Note that could extend sycl::device's lifetime past global_handler destruction when running our unittests, but that device wasn't really usable because we've already released all the UR resources at that point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #19613.
Refactoring has started in
#18143
#18251