[UR][OpenCL] Move banned platforms filtering to UR #20014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatKamin
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
PatKamin
force-pushed
the
banned-platforms-in-ur
branch
from
f262cbd to
467f2cf
Compare
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
PatKamin
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Filter out banned OpenCl platforms earlier, in the UR OpenCL adapter instead of the SYCL RT.
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Sep 9, 2025
|
Is there a reason this needs to be baked into the binary? Would having it be specified in a config file not mean it could be modified by vendors/sysadmins without having to rebuild DPCPP? |
| @@ -30,6 +30,35 @@ static cl_int mapURPlatformInfoToCL(ur_platform_info_t URPropName) { | |||
| } | |||
| } | |||
|
|
|||
| static bool isBannedOpenCLPlatform(cl_platform_id platform) { | |||
There was a problem hiding this comment.
We should also ban opencl:fpga. If device name is not known for fpga, can we filter on the basis of device type? Perhaps by using clGetDeviceInfo (https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_API.html#platform-querying-devices)
uditagarwal97
requested changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out banned OpenCl platforms earlier, in the UR OpenCL adapter instead of the SYCL RT.