Skip to content

Conversation

sgbihu
Copy link

@sgbihu sgbihu commented Aug 25, 2025

Description

Motivation and Context

@MayureshV1 MayureshV1 requested a review from Copilot August 26, 2025 00:03
Copilot

This comment was marked as outdated.

@sgbihu sgbihu requested a review from Copilot September 2, 2025 07:50
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses multiple OpenVINO execution provider compatibility issues to make onnxruntime tests pass. The changes primarily involve adjusting test tolerances and adding conditional skips for known OpenVINO limitations.

  • Updates test error thresholds for quantization and resize operations to accommodate OpenVINO's precision differences
  • Adds conditional test skips for OpenVINO when handling edge cases like empty tensors and negative slicing
  • Enhances tensor checking infrastructure to support absolute error validation for integer data types

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
slice_op.test.cc Adds OpenVINO skip for negative step slicing with INT_MAX ends
resize_op_test.cc Increases absolute error tolerance for uint8 resize operations
quantize_linear_test.cc Sets absolute error tolerance for various quantization data types
concat_op_test.cc Excludes OpenVINO from tests with zero-size inputs
cast_op_test.cc Adds OpenVINO skip for empty tensor casting
loop_test.cc Excludes OpenVINO from floating node tests
checkers.cc Enhances Int4x2, UInt4x2, uint8_t, and uint16_t tensor checkers with absolute error support
quantize_ops_test.cc Sets absolute error tolerance for contrib quantization operations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant