-
Notifications
You must be signed in to change notification settings - Fork 75
Implement JWT authentication for Intercom in React Native #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement JWT authentication for Intercom in React Native #298
Conversation
…, Android 17.0.+)
I am getting this from CI:
Please, fix |
@refactorer-bot Theres a conflict between the podfile and the podspec. Add a step in the circle-ci config to remove the podFile from the ios directory before running pod install |
🔧 Refactorer Status - Followup Complete ✅ (logs) Followup and polish completed successfully for PR OutcomePerfect! I've successfully addressed the CI issue by adding a step to remove the Podfile.lock before running
The fix adds a new step at This ensures the iOS e2e tests will use the correct Intercom SDK version (19.0.0) that supports JWT authentication, fixing the CI build failure. |
🤖 ✔️ I completed addressing the PR comments successfully. You should see a new commit with the requested changes. For any debugging the task ARN was arn:aws:ecs:us-east-1:123456789012:task/intercom-code-bot/bf483b70925d46cf838484bd248aa2e9. |
@refactorer-bot method is setUserJwt, not setUserJWT. Change it to reflect this |
🔧 Refactorer Status - Followup Complete ✅ (logs) Followup and polish completed successfully for PR OutcomePerfect! I have successfully addressed the feedback from the code review. Here's a summary of the changes made: Changes MadeI updated the method name from Files Updated:
Specific Changes:
The method name now follows standard camelCase convention ( |
🤖 ✔️ I completed addressing the PR comments successfully. You should see a new commit with the requested changes. For any debugging the task ARN was arn:aws:ecs:us-east-1:123456789012:task/intercom-code-bot/78390cb519184970bbcd3dd06ac6ae87. |
Closes: https://github.com/intercom/intercom/issues/413021
This pull request introduces JWT (JSON Web Token) authentication support for Intercom in our React Native application. The change is necessary to enhance security and align with Intercom's latest recommended practices for user authentication.
JWT offers several advantages over the previous HMAC-based approach, including enhanced security, more flexible token management, and better integration with modern authentication systems. By implementing JWT support, we're ensuring our app stays up-to-date with the latest security standards and can leverage the full capabilities of Intercom's user authentication system.
The changes include:
setUserJWT
method in the React Native bridge for both iOS and Android platforms.setUserJWT
method with proper documentation.setUserHash
method.These changes provide a more secure and flexible authentication mechanism for our Intercom integration, while maintaining compatibility with existing code. The implementation follows best practices, includes extensive error handling, and is thoroughly tested to ensure reliability across different scenarios.