feat(auth): add support for fullName when using Sign in with Apple #8570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to set the user's full name when using Sign In With Apple.
When signing in with Apple using e.g.
react-native-apple-authentication
, Apple provides afullName
value which must be displayed in the app; furthermore, Apple provides this data only on initial sign-up and not on subsequent sign-ins.firebase-ios-sdk
supports setting that value when signing in via Firebase with an Apple credential; however,react-native-firebase
does not currently provide a way to pass thefullName
value to the underlying Firebase native code. As a result, using Sign In With Apple requires storing the user's name data in the app instead of in Firebase as with other social auth providers.This PR adds a
signInWithAppleCredential
method to theauth
module, which passes thefullName
value toappleCredentialWithIDToken
in the Firebase iOS SDK so it can be forwarded to Firebase on sign-up.Notes:
AppleAuthProvider.credential
is extended to take an optionalfullName
parametersignInWithAppleCredential
accepts a credential with or without thefullName
propertysignInWithCredential
method is unchangedThis feature is iOS only; AFAICT this functionality is already handled by the Firebase Android SDK (docs).
Related issues
Fixes #7603
Release Summary
Adds ability to set
fullName
when using Sign In With AppleChecklist
Android
iOS
Other
(macOS, web)e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
I wasn't able to add e2e tests as the Firebase emulator doesn't support social auth, but I am running it in my own app:
🔥
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter