Skip to content

Conversation

hacki11
Copy link

@hacki11 hacki11 commented Apr 1, 2025

PR Checklist:

  • Provide a meaningful description to this PR or mention which issues this fixes.
  • Ensure the project builds with npm run build
  • Add tests for your change. This includes negative tests (i.e. inputs that need to fail) as well as baseline tests (i.e. how should the directory structure look like?).
  • Run the test suite with npm test
  • If there are baseline changes, review them and make a separate commit for them with the comment "accept baselines" if they are desired changes
  • N/A If you added a required option, also add it to the template creation (.github/create_templates.ts)
  • Add a detailed migration description to docs/updates explaining what the user needs to do when manually updating an existing project
  • Add your changes to CHANGELOG.md (referencing the migration description and this PR or the issue you fixed)

Description:
As a developer, I want to commit & push to the adapters git repository I cloned with a ssh url instead of https.
The current iobroker docker image does not include openssh-client, so ssh is not working. This PR changes that.

@hacki11
Copy link
Author

hacki11 commented Apr 1, 2025

How would you test such a change? Is there a test which validates that the DevContainer is actually working?

@hacki11
Copy link
Author

hacki11 commented Apr 10, 2025

@AlCalzone anything open from your side or can we merge this?

@hacki11 hacki11 requested a review from AlCalzone April 11, 2025 09:14
@Apollon77 Apollon77 requested a review from Copilot September 2, 2025 20:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds openssh-client to the devcontainer Docker image to enable SSH-based Git operations. This addresses a limitation where developers cannot commit and push to Git repositories cloned with SSH URLs because the base iobroker Docker image lacks SSH client support.

  • Installs openssh-client package in the devcontainer Dockerfile
  • Updates both template and baseline files to maintain consistency
  • Provides migration documentation for existing projects

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
test/baselines/devcontainer/.devcontainer/iobroker/Dockerfile Adds openssh-client installation to baseline Dockerfile
templates/_devcontainer/iobroker/_Dockerfile.ts Updates template to include openssh-client installation
docs/updates/20250401_devcontainer_ssh.md Provides migration guide for existing projects
CHANGELOG.md Documents the change with reference to migration guide

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants