-
Notifications
You must be signed in to change notification settings - Fork 27
add openssh-client to devcontainer #1136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
How would you test such a change? Is there a test which validates that the DevContainer is actually working? |
@AlCalzone anything open from your side or can we merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds openssh-client to the devcontainer Docker image to enable SSH-based Git operations. This addresses a limitation where developers cannot commit and push to Git repositories cloned with SSH URLs because the base iobroker Docker image lacks SSH client support.
- Installs openssh-client package in the devcontainer Dockerfile
- Updates both template and baseline files to maintain consistency
- Provides migration documentation for existing projects
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
test/baselines/devcontainer/.devcontainer/iobroker/Dockerfile | Adds openssh-client installation to baseline Dockerfile |
templates/_devcontainer/iobroker/_Dockerfile.ts | Updates template to include openssh-client installation |
docs/updates/20250401_devcontainer_ssh.md | Provides migration guide for existing projects |
CHANGELOG.md | Documents the change with reference to migration guide |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
PR Checklist:
npm run build
npm test
.github/create_templates.ts
)docs/updates
explaining what the user needs to do when manually updating an existing projectCHANGELOG.md
(referencing the migration description and this PR or the issue you fixed)Description:
As a developer, I want to commit & push to the adapters git repository I cloned with a ssh url instead of https.
The current iobroker docker image does not include openssh-client, so ssh is not working. This PR changes that.