Skip to content

Conversation

MathewBiddle
Copy link
Contributor

replaces #15

@MathewBiddle
Copy link
Contributor Author

I'm confused why the tests are failing.

This notebook is super clunky in that it saves a bunch of images to display in a popup. I wonder if ggplot has a cleaner way to do this?

@ocefpaf
Copy link
Member

ocefpaf commented May 5, 2023

This notebook is super clunky in that it saves a bunch of images to display in a popup. I wonder if ggplot has a cleaner way to do this?

This notebook is not failing. These ones are:

FAILED jupyterbook/content/code_gallery/data_analysis_and_visualization_notebooks/2018-12-04-grids.ipynb
FAILED jupyterbook/content/code_gallery/data_analysis_and_visualization_notebooks/2021-10-25-ERDDAP-interpolate.ipynb

The latter is usually the server blocking us or some downtime. See https://github.com/ioos/ioos_code_lab/actions/runs/4874207723/jobs/8694836345?pr=139#step:5:261, sadly it happens a lot with that server.

The former may be due to some data that moved around. See https://github.com/ioos/ioos_code_lab/actions/runs/4874207723/jobs/8694836345?pr=139#step:5:72

Anyway, those failures are not blockers for your PR and I'l address than ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants