-
Notifications
You must be signed in to change notification settings - Fork 33
Updated analyzer breaking changes and source_gen dependancies #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3
Are you sure you want to change the base?
Conversation
Thank you |
@vicenterusso A new release with updated dependencies would be much appreciated. |
I'm in the middle of the process of renaming this entire project to isar-community so we can use pub.dev directly. After initial tests I will thoroughly examine all opened PRs |
Great to hear and thank you for the quick reply 👍 If you need any help, please let me know. |
I will certainly need help with testing 😃 |
@vicenterusso let me know if I can help at all, I've got a bit of time to chip in if needed |
@vicenterusso I'm using Isar in a side project I'm getting paid for and would be happy to spend some of that paid time on assisting with testing or maintenance—please let me know as well. |
Sure! Do you develop on Windows or macOS by any chance? I need to find time to test the package renaming on those platforms. Android and Linux have already been renamed. This is the first step toward addressing all the other open issues. |
Yup, the application I'm maintaining is for desktop, so I have dev environments set up on both a Mac and a Windows machine along with Linux. |
@callumw-k @viskanic @jslater89 @saropa Hey! This is a bit of a clunky repo (v3 only) that includes a minimal sample and a semi-renamed version of Isar. Linux and Android are working, but Windows, macOS, and iOS still need some work. I believe only the files inside The minimal test project is already set up to pull the packages relatively from the current folder (check the Repo: https://github.com/vicenterusso/isar_renaming_test_bundle/ Feel free to open PRs and experiment! |
Hi all, any updates on this?! |
Any news? |
For Who waiting this merge. Change to
|
Thanks @docaohuynh - really appreciate this Btw, analyzer is up to v7.4.5 now, which could be beneficial https://pub.dev/packages/analyzer/changelog#745 We're operating on the idea that v4 won't be production-ready for the forseeable future. But in the meantime, a bump to v3 with this and other minor quality-of-life PRs would be really great! |
Hi! Just a quick follow-up to see if this PR could be reviewed and potentially merged soon 🙏 |
@vicenterusso this is well waited, hope merged soon 👍 |
All tests pass, I believe anaylzer depricated these values a while ago and 7.3.0 was the final removal. I don't have any build_runner errors or dependancy issues in my current project.
I've potentially been to liberal here, as I've fixed some dart lint errors as well. Happy to pair back a bit as required