-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ES] Issue #16684: pendings translations to Spanish #16691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES] Issue #16684: pendings translations to Spanish #16691
Conversation
Hi @fjglira. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test (Please join the GitHub org!) |
title: Bookinfo Application | ||
description: Deploys a sample application composed of four separate microservices used to demonstrate various Istio features. | ||
title: Aplicación Bookinfo | ||
description: Despliega una aplicación de ejemplo compuesta por cuatro microservices separados usados para demostrar varias características de Istio. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that we don't translate microservices to microservicios, is that intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I missed that. Let me check and replace it in all the places. There are other terms that I prefer not to translate it but this makes sense to have it in Spanish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preliminary review of the first ten files in the review view. There is still a few "microservices" and "microservice".
and go directly to [Define the service versions](/es/docs/examples/bookinfo/#define-the-service-versions). | ||
Si instalaste Istio usando las instrucciones de [Comenzando](/es/docs/setup/getting-started/), | ||
ya tienes Bookinfo instalado y puedes omitir la mayoría de estos pasos | ||
e ir directamente a [Definir las versiones del servicio](/es/docs/examples/bookinfo/#define-the-service-versions). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if these anchors are going to change with pages in spanish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we need to update this also. I'll add it to the issue to avoid addressing it on this PR. It will make the PR more difficult to review
* `details`. The `details` microservice contains book information. | ||
* `reviews`. The `reviews` microservice contains book reviews. It also calls the `ratings` microservice. | ||
* `ratings`. The `ratings` microservice contains book ranking information that accompanies a book review. | ||
* `productpage`. El microservice `productpage` llama a los microservicios `details` y `reviews` para poblar la página. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/microservice/microservicio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
||
{{< text bash >}} | ||
$ kubectl exec "$(kubectl get pod -l app=ratings -o jsonpath='{.items[0].metadata.name}')" -c ratings -- curl -sS productpage:9080/productpage | grep -o "<title>.*</title>" | ||
<title>Simple Bookstore App</title> | ||
{{< /text >}} | ||
|
||
### Determine the ingress IP and port | ||
### Determinar el IP de entrada y el puerto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't how is this example solved elsewhere, but I've always use (and heard) "la IP" as it's "la direccion IP".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll update it
title: Learn Microservices using Kubernetes and Istio | ||
description: This modular tutorial provides new users with hands-on experience using Istio for common microservices scenarios, one step at a time. | ||
title: Aprender microservicios usando Kubernetes e Istio | ||
description: Este tutorial modular proporciona a nuevos usuarios experiencia práctica usando Istio para escenarios comunes de microservices, paso a paso. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/microservices/microservicios
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
content/es/docs/examples/microservices-istio/logs-istio/index.md
Outdated
Show resolved
Hide resolved
content/es/docs/examples/microservices-istio/production-testing/index.md
Outdated
Show resolved
Hide resolved
I'll try to keep the PR in smaller batches, but there is still a lot of file to translate, so it will take a while |
content/es/blog/2024/in-cluster-operator-deprecation-announcement/index.md
Outdated
Show resolved
Hide resolved
Hey, I pushed more changes from your review. Do you want to add the pendings to the issue, and we can address this in a separate PR? I don't want to increase the size of the PR anymore to make it harder to review |
@fjglira let me do one full review. I've barely touched the real translations here. I'll post a review that we can then track in an issue |
@fjglira I reviewed 48 files of this PR. Will continue reviewing during the weekend. |
Hey @german1608, I think we can split the remaining files to avoid you from working on this during the weekend. I'll ask @josunect and @ferhoyos to get some help and split the remaining checks and I'm trying to get more eyes from the comunity |
I checked with both, and they are happy to help @german1608. I can split the PR into 3 PR's more and leave this PR until the file 48, according to my maths is: |
@fjglira i reviewed in total 64 files, you can split starting from After you split, I'll submit my review. |
08eac9d
to
5d3e20e
Compare
Signed-off-by: Francisco Herrera <[email protected]>
f45aa30
to
9a3c89a
Compare
Hey @german1608, I already did the split, the links of the PRs are linked to this PR:
I'll talk with Josune and Fernando to get two of them assigned to them. Thanks a lot for the help |
Signed-off-by: Francisco Herrera <[email protected]>
Signed-off-by: Francisco Herrera <[email protected]>
content/es/docs/examples/microservices-istio/setup-kubernetes-cluster/index.md
Show resolved
Hide resolved
Co-authored-by: German Robayo <[email protected]>
Signed-off-by: Francisco Herrera <[email protected]>
Thanks a lot for the review @german1608. @craigbox can we cherry-pick this to go live? This is solving issues and pending translations. Thanks in advance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cherry-pick release-1.26
In response to a cherrypick label: new pull request created: #16751 |
Description
#16684 part of the pending work related to the translation to Spanish.
I'll be splitting the work into multiple PR to avoid making them huge and more difficult to review. I added to this PR what I think were the more important remaining files. There are still several files pending translation, but these were the most important ones.
In a consecutive PR I'll continue addressing the remaining files pending translation
Reviewers