fix link to ECMA-262 specification #3691
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javascript-translate-bot
added
the
review needed
|
|
javascript-translate-bot
added
needs +1
|
This PR is incorrect. It arbitrarily links to the ancient v5.1 of the spec. The current link is fine. It just redirects to https://ecma-international.org/publications-and-standards/standards/ecma-262/ Three options:
Any of the above seem okay, but not accepting this PR as is. |
slevithan
suggested changes
Jun 18, 2024
| ## Specification | ||
|
|
||
| [The ECMA-262 specification](https://www.ecma-international.org/publications/standards/Ecma-262.htm) contains the most in-depth, detailed and formalized information about JavaScript. It defines the language. | ||
| [The ECMA-262 specification](https://262.ecma-international.org/5.1/) contains the most in-depth, detailed and formalized information about JavaScript. It defines the language. |
There was a problem hiding this comment.
Should link to the latest standard, not v5.1 from 2011.
javascript-translate-bot
added
the
changes requested
|
Please make the requested changes. After it, add a comment "/done". |
|
/done Thanks for the feedback. I think your option 3 would be best and changed it accordingly. |
javascript-translate-bot
added
review needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old link was broken