Skip to content

Add Safari like browser option #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

goinnn
Copy link
Member

@goinnn goinnn commented Jun 5, 2025

I think the WebPushDevice browser field should be removed. But in the meantime, I think we should add the Safari type to the options, as mentioned in this comment:

#673 (comment)

To remove the browser field, registration_id should be the full URL instead of only the token:

https://github.com/jazzband/django-push-notifications/blob/master/push_notifications/webpush.py#L10

But that will be a big change.

This PR fixes: The REST API is failing if we try to register a Safari WebPushDevice

Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.76%. Comparing base (44977b1) to head (66cc924).
Report is 59 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #776      +/-   ##
==========================================
+ Coverage   70.39%   72.76%   +2.37%     
==========================================
  Files          27       31       +4     
  Lines        1101     1252     +151     
  Branches      180      207      +27     
==========================================
+ Hits          775      911     +136     
- Misses        288      298      +10     
- Partials       38       43       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant