Add Safari like browser option #776
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the WebPushDevice browser field should be removed. But in the meantime, I think we should add the Safari type to the options, as mentioned in this comment:
#673 (comment)
To remove the browser field, registration_id should be the full URL instead of only the token:
https://github.com/jazzband/django-push-notifications/blob/master/push_notifications/webpush.py#L10
But that will be a big change.
This PR fixes: The REST API is failing if we try to register a Safari WebPushDevice