Fix webpush API #777
Open
Fix webpush API #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When registering a Web Push endpoint in the backend, it is essential to save the complete endpoint URL provided by the browser instead of just the token or identifier. This is because the full URL includes not only the device identifier but also the specific push service host, path and query parameters necessary for proper authentication and message delivery. These can change over time, storing only the token or a partial value risks losing the ability to send reliable and secure notifications, thus affecting the overall stability of the push notification system.
Therefore, the lookup_value_regex should allow for almost any character, as the value is sent from the frontend using encodeURIComponent, and URLs tend to be very complex and diverse.