-
Notifications
You must be signed in to change notification settings - Fork 74
[JENKINS-68480] Automatically select owner for GitHubAppCredentials #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@aaronwalker hi, do you have a moment to review and merge this pr? Multiple dependencies have been upgraded, I believe the Jenkinsfile also needs to be upgraded , I ran the compile on my pc and it works. |
@LeoQuote looks like an issue with the CI See https://github.com/jenkinsci/pipeline-github-plugin/runs/12449680268 |
@aaronwalker Thanks for your review, IMHO the error is caused by the outdated build environtment, the building system is using java 8 which is not supported in the latest jenkins server. would you consider merging #118 to bring build environment to the latest? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LeoQuote hate to be a pain but can you squash this into a single commit |
upgrade dependency to build
@aaronwalker certainly, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pr fix https://issues.jenkins.io/browse/JENKINS-68480 ,
like jenkinsci/github-branch-source-plugin#527 , it sets RepoOwner() context automatically , make it possible to call api when using github app credentials