Skip to content

[JENKINS-68480] Automatically select owner for GitHubAppCredentials #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

LeoQuote
Copy link

@LeoQuote LeoQuote commented Apr 1, 2023

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

This pr fix https://issues.jenkins.io/browse/JENKINS-68480 ,
like jenkinsci/github-branch-source-plugin#527 , it sets RepoOwner() context automatically , make it possible to call api when using github app credentials

@LeoQuote
Copy link
Author

LeoQuote commented Apr 1, 2023

Installed plugin in my jenkins instance, it made a comment successfully

图片

@LeoQuote
Copy link
Author

LeoQuote commented Apr 2, 2023

@aaronwalker hi, do you have a moment to review and merge this pr?

Multiple dependencies have been upgraded, I believe the Jenkinsfile also needs to be upgraded , I ran the compile on my pc and it works.

@aaronwalker
Copy link
Member

@LeoQuote looks like an issue with the CI See https://github.com/jenkinsci/pipeline-github-plugin/runs/12449680268

@LeoQuote
Copy link
Author

LeoQuote commented Apr 3, 2023

@aaronwalker Thanks for your review, IMHO the error is caused by the outdated build environtment, the building system is using java 8 which is not supported in the latest jenkins server.

would you consider merging #118 to bring build environment to the latest?

Copy link
Member

@aaronwalker aaronwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeoQuote I've merged PR #118 can you rebase this PR to confirm it resolves the build issues and I'll look to get the merge and released

@LeoQuote LeoQuote requested a review from aaronwalker April 4, 2023 10:42
@aaronwalker
Copy link
Member

@LeoQuote hate to be a pain but can you squash this into a single commit

@LeoQuote
Copy link
Author

LeoQuote commented Apr 4, 2023

@aaronwalker certainly, done.

Copy link
Member

@aaronwalker aaronwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronwalker aaronwalker merged commit 722725a into jenkinsci:master Apr 4, 2023
@LeoQuote LeoQuote deleted the patch-1 branch April 4, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants