Fix help display behaviors in the trait list UI #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap helpLink and helpArea in a `.help-sibling` container to ensure help content appears under the correct entry, rather than always in the first block. Also moved the helpLink inline with displayName inside the same <td> to improve layout. - Fixes confusing UX in repeatable entries - Matches Jenkins' help JavaScript behavior (finds closest `.help-sibling`) - Removes unnecessary <div> wrapping displayName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap helpLink and helpArea in a
.help-siblingcontainer to ensure help content appears under the correct entry, rather than always in the first block. Also moved the helpLink inline with displayName inside the same to improve layout..help-sibling)Before:
After:
Testing done
Submitter checklist