Fix issues with WebSocket UpgradeRequest after upgrade is complete #12877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lachlan-roberts status of this? |
Signed-off-by: Lachlan Roberts <[email protected]>
…egotiation Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
…grades Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts
force-pushed
the
fix/jetty-12.1.x/11294/WebSocketUpgradeRequest
branch
from
08df54b to
cceadba
Compare
…1.x/11294/WebSocketUpgradeRequest
|
@gregw this is ready for review now |
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts
added a commit
that referenced
this pull request
Jun 5, 2025
Signed-off-by: Lachlan Roberts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11294
JetterServerUpgradeRequestandJetterServerUpgradeResponseare only used for the webscoket negotiation, and are not available from theUpgradeRequestandUpgradeResponsewhich can be obtained from theSession.UpgradeRequestandUpgradeResponseinstances from theSessionare nowCompletedUpgradeRequest, which will copy any information it needs so it is not accessing the coreRequest/Responseafter the upgrade.WebSocketHandshaker.