Skip to content

Fixed several security vulnerabilities #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed several security vulnerabilities #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58c4df6
Update ImageShowController.java
Northind Feb 14, 2023
ad839fb
Update RegistController.java
Northind Feb 14, 2023
e89eed0
Update PersonController.java
Northind Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/jflyfox/modules/admin/image/controller/ImageShowController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public void list() {

// 排序
String orderBy = getBaseForm().getOrderBy();
if (StrUtils.isEmpty(orderBy)) {
if (StrUtils.isEmpty(orderBy) || orderBy.contains("(")) {
sql.append(" order by sort,id desc");
} else {
sql.append(" order by ").append(orderBy);
Expand Down
10 changes: 9 additions & 1 deletion src/main/java/com/jflyfox/modules/front/controller/PersonController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
import com.jflyfox.util.StrUtils;
import com.jflyfox.util.extend.HtmlUtils;

import java.util.regex.Matcher;
import java.util.regex.Pattern;

/**
* 个人信息
*
Expand Down Expand Up @@ -415,7 +418,12 @@ public void save() {
}
}

if (StrUtils.isNotEmpty(model.getStr("email")) && model.getStr("email").indexOf("@") < 0) {
String regEx1 = "^[\\w-_\\.+]*[\\w-_\\.]\\@([\\w]+\\.)+[\\w]+[\\w]$";
Pattern p;
Matcher m;
p = Pattern.compile(regEx1);
m = p.matcher(model.getStr("email"));
if(!m.matches()){
json.put("msg", "email格式错误！");
renderJson(json.toJSONString());
return;
Expand Down
10 changes: 9 additions & 1 deletion src/main/java/com/jflyfox/modules/front/controller/RegistController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
import com.jflyfox.system.user.UserCache;
import com.jflyfox.util.StrUtils;

import java.util.regex.Matcher;
import java.util.regex.Pattern;

@ControllerBind(controllerKey = "/front/regist")
public class RegistController extends BaseProjectController {

Expand Down Expand Up @@ -62,7 +65,12 @@ public void save() {
return;
}

if (StrUtils.isEmpty(key) || key.indexOf("@") < 0) {
String regEx1 = "^[\\w-_\\.+]*[\\w-_\\.]\\@([\\w]+\\.)+[\\w]+[\\w]$";
Pattern p;
Matcher m;
p = Pattern.compile(regEx1);
m = p.matcher(key);
if(!m.matches()) {
json.put("msg", "email格式错误！");
renderJson(json.toJSONString());
return;
Expand Down