Added glx.h to OpenGL.h and commented out a return statement. #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the compiler cannot process some of the lines in Raytracer.c I know because I personally tried to compile this game.
MinecraftC/Mods/Raytracer.c
Outdated
| @@ -164,7 +164,8 @@ void RaytracerReload() { | |||
| error |= clSetKernelArg(Raytracer.traceKernel, 2, sizeof(cl_mem), &Raytracer.blockBuffer); | |||
| if (error < 0) { | |||
| LogError("Failed to set kernel arguments: %i\n", error); | |||
| return false; | |||
| //return false; | |||
There was a problem hiding this comment.
not sure why the return false was there, must've been an oversight. Remove the comments and i'll approve, thanks
There was a problem hiding this comment.
I think it's done. Could you just double check before approval?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glx.h helps with linux compilation, without it the functions
glXGetCurrentContextandglXGetCurrentDisplayin raytracer.c don't get recgonised.Also I commented out a
return false;because it was inside a void function.With these changes, I was able to compile the game on my linux machine. There are some things still need working on, like OpenCL-ICD-Loader just gives me headaches when trying to compile, but that's not this repo's problem :)