Skip to content

[5.3] - Allow fancy-select renderSelectedChoices attribute to be overridden #45558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: 5.3-dev
Choose a base branch
from
Open

[5.3] - Allow fancy-select renderSelectedChoices attribute to be overridden #45558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4c56842
allow renderSelectedChoices to be overwritten by data attrib
travisrisner May 30, 2025
22f3893
set render selected choices to auto on just fields without nested values
travisrisner May 30, 2025
a6d2148
swap from data attribute in xml to traditional field
travisrisner Jun 3, 2025
05e1784
swap back to data attribute version
travisrisner Jun 3, 2025
dc239e9
Update administrator/components/com_actionlogs/config.xml
travisrisner Jun 11, 2025
9f0a2f7
fix tab issues in xml files
travisrisner Jun 11, 2025
d54ab5f
fix tab issue in xml
travisrisner Jun 11, 2025
2c180df
Update plugins/workflow/notification/notification.xml
travisrisner Jun 11, 2025
536d721
Update plugins/schemaorg/organization/organization.xml
travisrisner Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions administrator/components/com_actionlogs/config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
multiple="true"
layout="joomla.form.field.list-fancy-select"
default="com_banners,com_cache,com_categories,com_checkin,com_config,com_contact,com_content,com_fields,com_guidedtours,com_installer,com_media,com_menus,com_messages,com_modules,com_newsfeeds,com_plugins,com_redirect,com_scheduler,com_tags,com_templates,com_users"
data-render-selected-choices="auto"
/>
<field
name="loggable_api"
Expand All @@ -52,6 +53,7 @@
default="GET"
validate="options"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
>
<option value="GET">COM_ACTIONLOGS_FIELD_VALUE_GET</option>
<option value="POST">COM_ACTIONLOGS_FIELD_VALUE_POST</option>
Expand Down
1 change: 1 addition & 0 deletions administrator/components/com_config/forms/application.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,6 +1182,7 @@
layout="joomla.form.field.list-fancy-select"
default="all"
validate="options"
data-render-selected-choices="auto"
>
<option value="all">COM_CONFIG_FIELD_LOG_PRIORITIES_ALL</option>
<option value="emergency">COM_CONFIG_FIELD_LOG_PRIORITIES_EMERGENCY</option>
Expand Down
1 change: 1 addition & 0 deletions administrator/components/com_contact/config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,7 @@
context="com_users.user"
addfieldprefix="Joomla\Component\Fields\Administrator\Field"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
>
<option value="-1">JALL</option>
</field>
Expand Down
1 change: 1 addition & 0 deletions administrator/components/com_contact/forms/contact.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,7 @@
context="com_users.user"
addfieldprefix="Joomla\Component\Fields\Administrator\Field"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
>
<option value="-1">JALL</option>
</field>
Expand Down
2 changes: 2 additions & 0 deletions administrator/components/com_content/forms/filter_articles.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
layout="joomla.form.field.list-fancy-select"
hint="JOPTION_SELECT_ACCESS"
class="js-select-submit-on-change"
data-render-selected-choices="auto"
/>

<field
Expand All @@ -74,6 +75,7 @@
layout="joomla.form.field.list-fancy-select"
hint="JOPTION_SELECT_AUTHOR"
class="js-select-submit-on-change"
data-render-selected-choices="auto"
>
<option value="0">JNONE</option>
<option value="by_me">COM_CONTENT_FILTER_AUTHORS_BY_ME</option>
Expand Down
2 changes: 2 additions & 0 deletions administrator/components/com_content/forms/filter_featured.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
layout="joomla.form.field.list-fancy-select"
hint="JOPTION_SELECT_ACCESS"
class="js-select-submit-on-change"
data-render-selected-choices="auto"
/>

<field
Expand All @@ -60,6 +61,7 @@
layout="joomla.form.field.list-fancy-select"
hint="JOPTION_SELECT_AUTHOR"
class="js-select-submit-on-change"
data-render-selected-choices="auto"
>
<option value="0">JNONE</option>
</field>
Expand Down
2 changes: 2 additions & 0 deletions administrator/components/com_content/tmpl/articles/default.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
layout="joomla.form.field.list-fancy-select"
class="multipleAuthors"
filter="array"
data-render-selected-choices="auto"
>
<option value="0">JNONE</option>
<option value="by_me">COM_CONTENT_FILTER_AUTHORS_BY_ME</option>
Expand All @@ -67,6 +68,7 @@
layout="joomla.form.field.list-fancy-select"
filter="intarray"
validate="options"
data-render-selected-choices="auto"
/>

<field
Expand Down
1 change: 1 addition & 0 deletions administrator/components/com_guidedtours/forms/tour.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
default="*"
data-render-selected-choices="auto"
>
<option value="*">JALL</option>
</field>
Expand Down
2 changes: 2 additions & 0 deletions administrator/components/com_users/config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@
layout="joomla.form.field.list-fancy-select"
client="site"
multiple="1"
data-render-selected-choices="auto"
/>

<field
Expand All @@ -250,6 +251,7 @@
layout="joomla.form.field.list-fancy-select"
client="administrator"
multiple="1"
data-render-selected-choices="auto"
/>

<field
Expand Down
2 changes: 1 addition & 1 deletion build/media_source/system/js/fields/joomla-field-fancy-select.w-c.es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ window.customElements.define('joomla-field-fancy-select', class extends HTMLElem
searchFloor: this.minTermLength,
searchResultLimit: parseInt(this.select.dataset.maxResults, 10) || 10,
renderChoiceLimit: parseInt(this.select.dataset.maxRender, 10) || -1,
renderSelectedChoices: 'always',
renderSelectedChoices: this.select.dataset.renderSelectedChoices || 'always',
shouldSort: false,
fuseOptions: {
threshold: 0.3, // Strict search
Expand Down
1 change: 1 addition & 0 deletions components/com_contact/tmpl/category/default.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,6 +672,7 @@
context="com_users.user"
addfieldprefix="Joomla\Component\Fields\Administrator\Field"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
>
<option value="-1">JALL</option>
</field>
Expand Down
1 change: 1 addition & 0 deletions components/com_finder/tmpl/search/default.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,7 @@
multiple="true"
validate="options"
showon="show_sort_order:1"
data-render-selected-choices="auto"
>
<option value="relevance">COM_FINDER_CONFIG_SORT_OPTION_RELEVANCE</option>
<option value="title">COM_FINDER_CONFIG_SORT_OPTION_TITLE</option>
Expand Down
1 change: 1 addition & 0 deletions components/com_tags/tmpl/tag/default.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
label="COM_TAGS_FIELD_TYPE_LABEL"
layout="joomla.form.field.list-fancy-select"
multiple="true"
data-render-selected-choices="auto"
/>

<field
Expand Down
1 change: 1 addition & 0 deletions components/com_tags/tmpl/tag/list.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
label="COM_TAGS_FIELD_TYPE_LABEL"
layout="joomla.form.field.list-fancy-select"
multiple="true"
data-render-selected-choices="auto"
/>

<field
Expand Down
2 changes: 2 additions & 0 deletions modules/mod_articles/mod_articles.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,7 @@
filter="intarray"
class="multipleAuthors"
showon="author_filtering_type!:2"
data-render-selected-choices="auto"
/>

<field
Expand Down Expand Up @@ -572,6 +573,7 @@
key_field="created_by_alias"
value_field="created_by_alias"
class="multipleAuthorAliases"
data-render-selected-choices="auto"
/>

<field
Expand Down
2 changes: 2 additions & 0 deletions modules/mod_articles_category/mod_articles_category.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@
layout="joomla.form.field.list-fancy-select"
filter="intarray"
class="multipleAuthors"
data-render-selected-choices="auto"
/>

<field
Expand Down Expand Up @@ -198,6 +199,7 @@
key_field="created_by_alias"
value_field="created_by_alias"
class="multipleAuthorAliases"
data-render-selected-choices="auto"
/>

<field
Expand Down
1 change: 1 addition & 0 deletions modules/mod_articles_latest/mod_articles_latest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@
multiple="true"
layout="joomla.form.field.list-fancy-select"
showon="user_id:created_by"
data-render-selected-choices="auto"
/>
</fieldset>

Expand Down
1 change: 1 addition & 0 deletions plugins/fields/editor/editor.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
folder="editors-xtd"
multiple="true"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>

<field
Expand Down
1 change: 1 addition & 0 deletions plugins/fields/url/params/url.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
multiple="true"
layout="joomla.form.field.list-fancy-select"
validate="options"
data-render-selected-choices="auto"
>
<option value="http">HTTP</option>
<option value="https">HTTPS</option>
Expand Down
1 change: 1 addition & 0 deletions plugins/fields/url/url.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
multiple="true"
layout="joomla.form.field.list-fancy-select"
validate="options"
data-render-selected-choices="auto"
>
<option value="http">HTTP</option>
<option value="https">HTTPS</option>
Expand Down
2 changes: 2 additions & 0 deletions plugins/schemaorg/article/article.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
description="JSCHEMAORG_EXTENSION_ALLOWED_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
<field
name="forbiddenlist"
Expand All @@ -36,6 +37,7 @@
description="JSCHEMAORG_EXTENSION_FORBIDDEN_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
</fieldset>
</fields>
Expand Down
2 changes: 2 additions & 0 deletions plugins/schemaorg/blogposting/blogposting.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
description="JSCHEMAORG_EXTENSION_ALLOWED_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
<field
name="forbiddenlist"
Expand All @@ -36,6 +37,7 @@
description="JSCHEMAORG_EXTENSION_FORBIDDEN_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
</fieldset>
</fields>
Expand Down
2 changes: 2 additions & 0 deletions plugins/schemaorg/book/book.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
description="JSCHEMAORG_EXTENSION_ALLOWED_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
<field
name="forbiddenlist"
Expand All @@ -36,6 +37,7 @@
description="JSCHEMAORG_EXTENSION_FORBIDDEN_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
</fieldset>
</fields>
Expand Down
2 changes: 2 additions & 0 deletions plugins/schemaorg/custom/custom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
description="JSCHEMAORG_EXTENSION_ALLOWED_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
<field
name="forbiddenlist"
Expand All @@ -36,6 +37,7 @@
description="JSCHEMAORG_EXTENSION_FORBIDDEN_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
</fieldset>
</fields>
Expand Down
2 changes: 2 additions & 0 deletions plugins/schemaorg/event/event.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
description="JSCHEMAORG_EXTENSION_ALLOWED_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
<field
name="forbiddenlist"
Expand All @@ -36,6 +37,7 @@
description="JSCHEMAORG_EXTENSION_FORBIDDEN_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
</fieldset>
</fields>
Expand Down
2 changes: 2 additions & 0 deletions plugins/schemaorg/jobposting/jobposting.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
description="JSCHEMAORG_EXTENSION_ALLOWED_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
<field
name="forbiddenlist"
Expand All @@ -36,6 +37,7 @@
description="JSCHEMAORG_EXTENSION_FORBIDDEN_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
</fieldset>
</fields>
Expand Down
2 changes: 2 additions & 0 deletions plugins/schemaorg/organization/organization.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
description="JSCHEMAORG_EXTENSION_ALLOWED_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
<field
name="forbiddenlist"
Expand All @@ -36,6 +37,7 @@
description="JSCHEMAORG_EXTENSION_FORBIDDEN_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
</fieldset>
</fields>
Expand Down
2 changes: 2 additions & 0 deletions plugins/schemaorg/person/person.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
description="JSCHEMAORG_EXTENSION_ALLOWED_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
<field
name="forbiddenlist"
Expand All @@ -36,6 +37,7 @@
description="JSCHEMAORG_EXTENSION_FORBIDDEN_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
</fieldset>
</fields>
Expand Down
2 changes: 2 additions & 0 deletions plugins/schemaorg/recipe/recipe.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
description="JSCHEMAORG_EXTENSION_ALLOWED_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
<field
name="forbiddenlist"
Expand All @@ -36,6 +37,7 @@
description="JSCHEMAORG_EXTENSION_FORBIDDEN_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
</fieldset>
</fields>
Expand Down
1 change: 1 addition & 0 deletions plugins/system/actionlogs/forms/actionlogs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
layout="joomla.form.field.list-fancy-select"
showon="actionlogsNotify:1"
default="com_content"
data-render-selected-choices="auto"
/>
</fields>
</fieldset>
Expand Down
1 change: 1 addition & 0 deletions plugins/system/httpheaders/httpheaders.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@
class="col-md-4"
validate="options"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
>
<option value="base-uri">base-uri</option>
<option value="block-all-mixed-content">block-all-mixed-content</option>
Expand Down
2 changes: 2 additions & 0 deletions plugins/workflow/featuring/featuring.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
description="JWORKFLOW_EXTENSION_ALLOWED_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
<field
name="forbiddenlist"
Expand All @@ -37,6 +38,7 @@
description="JWORKFLOW_EXTENSION_FORBIDDEN_DESCRIPTION"
multiple="multiple"
layout="joomla.form.field.list-fancy-select"
data-render-selected-choices="auto"
/>
</fieldset>
</fields>
Expand Down
Loading