Skip to content

[6.0] Remove call to 'toPunycode' which throws error for files with '_' #45627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 6.0-dev
Choose a base branch
from

Conversation

MacJoom
Copy link
Contributor

@MacJoom MacJoom commented Jun 19, 2025

Pull Request for Issue #45484.

Summary of Changes

Remove call to 'toPunycode' in getSafeName which throws error for files with underscores

Testing Instructions

  • Upload files with underscores in the name
  • Upload all kind of files with weird filenames
    File should upload. Special chars should be changed in the uploaded filename

Actual result BEFORE applying this Pull Request

Nothing happens - see Issue

Expected result AFTER applying this Pull Request

File is uploaded

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Fedik Fedik added the bug label Jun 19, 2025
@brianteeman
Copy link
Contributor

brianteeman commented Jun 19, 2025

this PR is not correct. Before this PR if you have a filename using ut8 characters it will be uploaded and cleaned
with this PR the file is simply not uploaded

Test by creating an image with the filename imageäöütest.jpg

Before this pr it will be saved as imageaoutest.jpg

With this pr nothing happens to the image

unrelated bug

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 48f40f8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45627.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 48f40f8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45627.

@richard67 richard67 changed the title Remove call to 'toPunycode' which throws error for files with '_' [6.0] Remove call to 'toPunycode' which throws error for files with '_' Jun 19, 2025
@exlemor
Copy link

exlemor commented Jun 19, 2025

I have tested this item ✅ successfully on 48f40f8

I have test this successfully with: imageäöütest.jpg, acs-delivering_package2_copy.jpg and imageäöütest_pack_test.jpg all were uploaded with appropriate substitution.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45627.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45627.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PR-6.0-dev Release Blocker RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants