-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.0] Remove call to 'toPunycode' which throws error for files with '_' #45627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.0-dev
Are you sure you want to change the base?
[6.0] Remove call to 'toPunycode' which throws error for files with '_' #45627
Conversation
unrelated bug |
I have tested this item 🔴 unsuccessfully on 48f40f8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45627. |
I have tested this item ✅ successfully on 48f40f8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45627. |
I have tested this item ✅ successfully on 48f40f8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45627. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45627. |
Pull Request for Issue #45484.
Summary of Changes
Remove call to 'toPunycode' in getSafeName which throws error for files with underscores
Testing Instructions
File should upload. Special chars should be changed in the uploaded filename
Actual result BEFORE applying this Pull Request
Nothing happens - see Issue
Expected result AFTER applying this Pull Request
File is uploaded
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed