-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.0] Add Support for Github Codespaces #45719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yes this is expected after building the container, but you can always start a new terminal |
thanks - was just checking |
Then I suggest a change in the text is required because it currently says
and that fails because the first test is installation and that will fail for the reasons above |
okay, what do you suggest i should change the text to? i want to also add that you can use |
I just edited some of the joomla config names to match Cypress config' default values, and got Cypress to run and pass all tests, except 2 test files that had 2 errors each I would love to hear some feedback about the setup and if someone can direct me on how fix the last errors, this exact error was mentioned in #44434 but had no actual solution |
even it is a temporay fix , as it is already done in other plcaes, you can do the same where tests are failing joomla-cms/tests/System/integration/site/components/com_contact/Router.cy.js Lines 8 to 11 in 704aefc
|
This is great work, thanks. But we need also proper documentation so it will get attention and can be used for testing pr's. |
Okay sure
Thank you, Are we talking about documentation for the Joomla manual or where exactly? I'm willing to write a documentation for this feature |
Hi @mahmoudmagdy1-1 would really like to get this in 6.0 but you only have days before the beta, can you write the documentation and just check through the comments and @Bodge-IT and I will try and get some tests |
this pr doesnt include any production code so shouldnt be tied to the release of j6 |
imho should be backported to 5.3 / 5.4 as can help with the upcoming PBF |
for 6.0 |
update to php 8.3. for 6.0
Hey @softforge, Like brian mentioned, it's not tied to the release of j6, it should work on all versions (5.3-dev, 5.4-dev) as well
Sure, I'm working on it right now, I think the best place for it, is : https://manual.joomla.org/docs/testing/manually Thanks for the pr @alikon |
Thank you for your work to date. I had just posted it back into maintainers to ask for the process and open the discussion there. I'll let you know as soon as I have an answer. |
Thanks, I've also just added the documentation for this feature and put the link of the docs in the pr description |
I have tested this item ✅ successfully on 371e787 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45719. |
it would be good to have this pr merged for the upcoming PBF |
I have tested this item ✅ successfully on 7753b0d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45719. |
Thank you very much for all the work on this and the patience. Now it is time to spread the word. |
Continuation of #45552
Summary of Changes
a fully Joomla stack : fresh joomla installation with phpmyadmin,xdebug,cypress
This PR adds the ability to test other PRs using GitHub Codespaces, or even use it as a full development environment.
you can access the database directly using phpmyadmin, and run tests using Cypress, you can find more details in the codespace-details.txt file after creating the codespace with this PR
Testing Instructions
.devcontainer
filesgithub.dev
codespace-details.txt
Actual result BEFORE applying this Pull Request
N/A
Expected result AFTER applying this Pull Request
An easy way to test PRs on the cloud without setting everything up manually and on your local machine
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Add Docs for Github Codespaces Manual#496
No documentation changes for manual.joomla.org needed