fix: improve compatibility of loadstart/load/loadend events #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved dispatch of loadstart event to send()
Native XHR fires the
loadstart
event right afterxhr.send()
, soxhr.addEventListener(“loadstart”, listener)
can be placed either before or afterxhr.open()
.xhook currently dispatches
loadstart
insideopen()
. Ifxhr.open()
is called beforexhr.addEventListener(“loadstart”, listener)
, that listener will not work.This issue is fixed by moving the
loadstart
dispatch tosend()
.I noticed an interesting comment just before the loadstart dispatch, but personally, I think we should imitate the behavior of native XHR.
included ProgressEvent-specific properties in loadstart/load/loadend
In native XHR, the
loadstart/load/loadend
events areProgressEvent
and have specific properties (lengthComputable
,loaded
,total
).These were missing from the xhook events, so I added them.
{ lengthComputable, loaded, total }
in a private variable (lastProgress).