Skip to content

Conversation

GwendolenLynch
Copy link
Contributor

This PR aims to introduce testing for newer PostGIS versions.

One of the problems to solve was consistent, future-proof(-ish), testing across 5 different versions of PostGIS, as a test expectation might be valid for 3.0, 3.1 & 3.2, but changes in 3.3 and/or 3.4 due to the way PHPUnit handles --group and --exclude-group, e.g. if a test is in 3.1 & 3.2, but you --exclude-group on 3.1, then the 3.2 group membership is ignored.

To work around this I added a small function to the generator that automatically add group membership to a catch-all versioned group, and for the highest-value group, any higher supported group values.

Tests (e.g. PostgreSQL 13 & PostGIS 3.2) now can be run like so :

./docker/run-13-32.sh vendor/bin/phpunit --exclude-group=versioned
./docker/run-13-32.sh vendor/bin/phpunit --group=postgis-3.2

I haven't touched the CI yet, as you'll probably have feedback with respect to PHP & Postgres versions used in the matrix.

Happy to work with you to get things to your liking.

@GwendolenLynch
Copy link
Contributor Author

I've made a first attempt at updating the CI matrix, so there should be more to see on the next run.

Copy link
Collaborator

@maxhelias maxhelias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But you should update version. Postgres 17 and PostGIS 3.5

This was referenced Oct 8, 2025
@maxhelias maxhelias force-pushed the postgis-next branch 9 times, most recently from c1f28f6 to 4a061f9 Compare October 8, 2025 13:13
@maxhelias maxhelias changed the title Support for PostGIS 3.2, 3.3 & 3.4 testing Support for PostGIS 3.2, 3.4 & 3.6 testing Oct 9, 2025
@maxhelias maxhelias merged commit 0db64e9 into jsor:main Oct 9, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants