Add buildpack for pyproject.toml to configure container image #1444
+152
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgaiacs
force-pushed
the
1427-support-pyproject
branch
from
83b5f11 to
577cb1b
Compare
rgaiacs
changed the title
|
577cb1b implements a minimal working version. It was tested with https://github.com/rgaiacs/binder-examples-pyproject. Required changes before merge
Changes that can be done in another pull request
|
minrk
reviewed
Aug 18, 2025
Comment on lines
129
to
131
| """PATH="${KERNEL_PYTHON_PREFIX}/bin:$PATH" \\ | ||
| pip install --no-cache-dir --editable . | ||
| """, |
There was a problem hiding this comment.
Can we do:
Suggested change
| """PATH="${KERNEL_PYTHON_PREFIX}/bin:$PATH" \\ | |
| pip install --no-cache-dir --editable . | |
| """, | |
| "${KERNEL_PYTHON_PREFIX}/bin/python3 -m pip install --no-cache-dir --editable .", |
to be even more explicit than relying on $PATH?
rgaiacs
changed the title
because of tomllib.
since Python 3.9 is no longer supported as it does not have tomllib.
because now repo2docker requires Python >= 3.11 given the requirement of tomllib.
|
All tests are passing after support to Python < 3.11 was dropped. |
I've got a PR that refactors the handling of runtime.txt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1427
This is not yet ready for review!The code is based on the Pipfile buildpack. We probably want to refactor some portions to avoid code duplication.