-
-
Notifications
You must be signed in to change notification settings - Fork 16
Add support for drag and drop while editing message. #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks @nakul-py for working on this. It seems that it does not handle several editions, neither dropping the file to the main input while editing. output.webmI wonder if there is a way to drop the file in any input and add the attachment to that input. |
Gonna fixing it :). Thanks for Attention! |
b020775
to
9c87b6a
Compare
bacd4b3
to
b08a9fd
Compare
Yes! Each input now has a unique |
@brichet Any suggestion to make code changes more robust. |
@brichet Now what we can do ahead as this is first time someone opens a PR to my branch? |
If you agree with the changes, you can just merge it, it will update your branch. |
@brichet I have tested this and its working very good. :) |
chatCommandRegistry={props.chatCommandRegistry} | ||
toolbarRegistry={inputToolbarRegistry} | ||
/> | ||
<div className="jp-chat-input-container" data-input-id={model.input.id}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This container is probably not necessary anymore (looks like I forgot to remove it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok i will look into it!
Adding support for drag and drop files while editing messages in chat input.
Screencast.From.2025-09-28.20-29-12.mp4