[bootloose image] Infer helm version from go mod #5861
Conversation
|
I'd either do the version detection as we do it for k0sctl, so that we can rely on dependabot, or remove the interest completely. |
juanluisvaladas
force-pushed
the
fix-helm-version
branch
2 times, most recently
from
4f57a91 to
f54ba5e
Compare
|
That's much saner, I changed it so that we just infer it from go.mod using |
juanluisvaladas
force-pushed
the
fix-helm-version
branch
from
f54ba5e to
c13a0e7
Compare
juanluisvaladas
changed the title
inttest/Makefile
Outdated
| @@ -19,6 +19,7 @@ bin: | |||
| bin/sonobuoy: | bin | |||
| $(curl) $(sonobuoy_url) | tar -C bin/ -zxv $(notdir $@) | |||
|
|
|||
| helm_version = $(strip $(subst v,,$(shell cd .. && go list -m -f '{{.Version}}' helm.sh/helm/v3 2>/dev/null))) | |||
There was a problem hiding this comment.
Hmm, usually this is handled via vars.sh, but that's in the repo root and not part of the inttest folder ... 🤔 But since we have a cd .. in here anyways, I'd prefer sth. like ../vars.sh FROM=.. helm_version.
Or, since we're already looking into Renovate, we could just leave the version here around and add a regex pattern that bundles the updates 🤔
There was a problem hiding this comment.
That was my initial intention but I think this is saner.
Anyway I changed it to use vars.sh
Fix the mismatch between go.mod and embedded-bins/Makefile.variables once and for all. Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]>
juanluisvaladas
force-pushed
the
fix-helm-version
branch
from
c13a0e7 to
4231a2f
Compare
|
This pull request has merge conflicts that need to be resolved. |
Description
Fix the mismatch between
go.modandembedded-bins/Makefile.variables