Skip to content

Remount sysctl paths in Docker entrypoint #5958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jun 11, 2025

Description

Kubelet attempts to enforce certain sysctl tunables in /proc/sys. If the host configuration differs from what kubelet expects, errors may occur, such as "Failed to start ContainerManager: open /proc/sys/kernel/panic: read-only file system" or similar. Mitigate this by remounting /proc/sys in read-write mode if necessary.

The tunables only need to be set once and will stay in place until the next time the host reboots. If the values match the kubelet's expectations, the containers could get away with a read-only /proc/sys. This is inconvenient. Therefore, perform an automatic remount. Users may opt out of this via an environment variable.

Reference: https://github.com/kubernetes/kubernetes/blob/v1.33.1/pkg/kubelet/cm/container_manager_linux.go#L412

Note that if kubelet is running in a user namespace and the KubeletInUserNamespace alpha feature gate is enabled, kubelet will ignore any errors when setting tunables.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Kubelet attempts to enforce certain sysctl tunables in /proc/sys. If the
host configuration differs from what kubelet expects, errors may occur,
such as "Failed to start ContainerManager: open /proc/sys/kernel/panic:
read-only file system" or similar. Mitigate this by remounting /proc/sys
in read-write mode if necessary.

The tunables only need to be set once and will stay in place until
the next time the host reboots. If the values match the kubelet's
expectations, the containers could get away with a read-only /proc/sys.
This is inconvenient. Therefore, perform an automatic remount. Users may
opt out of this via an environment variable.

Note that if kubelet is running in a user namespace and the
KubeletInUserNamespace alpha feature gate is enabled, kubelet will
ignore any errors when setting tunables.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added the enhancement New feature or request label Jun 11, 2025
@twz123 twz123 marked this pull request as ready for review June 11, 2025 14:27
@twz123 twz123 requested review from a team as code owners June 11, 2025 14:27
@twz123 twz123 requested review from ncopa and juanluisvaladas June 11, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant