Skip to content

Use OS tests in release workflow #6030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jun 23, 2025

Description

Replace the Kubernetes conformance testing in the release workflow with workflow calls to the OS tests. This eliminates quite some duplicate code, and re-uses code that's more tested in the day to day pipelines. Also, this will remove some hard-coded versions from the codebase.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@twz123 twz123 force-pushed the ostests-in-release branch from 63a65b8 to c9cdb1f Compare June 23, 2025 14:32
@twz123 twz123 force-pushed the ostests-in-release branch from c9cdb1f to 40cb63f Compare June 25, 2025 08:44
twz123 added 6 commits June 26, 2025 09:55
This brings it on par with what build-k0s.yaml does and allows for using
the built binaries in the OS tests.

Signed-off-by: Tom Wieczorek <[email protected]>
The full conformance test suite seems to take longer.

Signed-off-by: Tom Wieczorek <[email protected]>
The contents=write permission is required in order to create tags and
releases, and to upload release assets.

Signed-off-by: Tom Wieczorek <[email protected]>
Replace the Kubernetes conformance testing in the release workflow
with workflow calls to the OS tests.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 force-pushed the ostests-in-release branch from 40cb63f to 8283bca Compare June 26, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant