Skip to content

Improving governance doc with vendor neutrality and vote sceanrios #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RainbowMango
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:
Improving governance doc with more explicit vendor neutrality and matters requires a 2/3 majority vote.

Which issue(s) this PR fixes:
Fixes #136
Part of #119

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Jun 23, 2025
@RainbowMango RainbowMango requested a review from Copilot June 23, 2025 03:55
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 23, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the governance documentation by clarifying vendor neutrality and outlining specific actions that require a two-thirds majority vote.

  • Updates the maintainers section with a vendor neutrality clause limiting any single vendor to less than 50% of the seats.
  • Introduces a numbered list specifying actions that require a two-thirds majority vote.
Comments suppressed due to low confidence (1)

GOVERNANCE.md:45

  • Consider inserting a space after the closing backtick before 'This' to improve readability.
than 50% of maintainer seats`.This may change as the community grows, such as by 

@RainbowMango RainbowMango force-pushed the pr_governance_vendor_neturality branch from a35d29b to 450ae05 Compare June 23, 2025 03:56
@lfbear
Copy link
Member

lfbear commented Jun 23, 2025

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2025
Copy link
Member

@kevin-wangzefeng kevin-wangzefeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for codifying this.

/hold
Holding this to ensure we reach a 2/3 majority vote by current maintainers before being merged.
/cc @mrlihanbo @carmark @GitHubxsy @wawa0210 @zoroyouxi @lfbear

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2025
@kevin-wangzefeng kevin-wangzefeng dismissed their stale review June 23, 2025 04:44

dismissing github approval to avoid unepxected merge

@kevin-wangzefeng kevin-wangzefeng removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Governance] Improving Governance Doc with More Explicit Vendor Neutrality and Maintainer Seat Limits
4 participants