Skip to content

[WIP] ✨ Update to code-generator/v3 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: kcp-1.32.3
Choose a base branch
from

Conversation

ntnn
Copy link
Member

@ntnn ntnn commented Jun 17, 2025

Summary

Build with the new and improved code-generator/v3

See #46 without the code-gen noise

Related issue(s)

Requires kcp-dev/code-generator#111
Closes #46

@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Jun 17, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sttts for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 17, 2025
@ntnn ntnn force-pushed the update-code-gen branch 3 times, most recently from 13a6c72 to 69af9fb Compare June 17, 2025 23:00
ntnn added 5 commits June 18, 2025 01:23
@ntnn ntnn force-pushed the update-code-gen branch from 69af9fb to a48cfee Compare June 17, 2025 23:24
@ntnn ntnn changed the title [WIP] ✨ Update to code-generator/v3 ✨ Update to code-generator/v3 Jun 17, 2025
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2025
Signed-off-by: Nelo-T. Wallus <[email protected]>
@ntnn ntnn changed the title ✨ Update to code-generator/v3 [WIP] ✨ Update to code-generator/v3 Jun 18, 2025
@kcp-ci-bot kcp-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2025
@ntnn
Copy link
Member Author

ntnn commented Jun 18, 2025

Setting to WIP again - the kcp unit and integration tests are working fine but I'm getting reproducible errors in the e2e tests.

ntnn added 7 commits June 30, 2025 12:42
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
@kcp-ci-bot
Copy link
Contributor

@ntnn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-client-go-verify 940cbc2 link true /test pull-client-go-verify

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants