Skip to content

This and that: 20241024-02 #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 24, 2024
Merged

This and that: 20241024-02 #530

merged 4 commits into from
Oct 24, 2024

Conversation

@amotl
Copy link
Collaborator

@amotl amotl commented Oct 24, 2024

About

After GH-529, another round of improvements submitted as a bundle.

References

@coderabbitai
Copy link

coderabbitai bot commented Oct 24, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The changes made in this pull request include updates to the README.md, requirements-dev.txt, responder/__main__.py, and setup.py files. The README.md now features updated badge links and clearer installation instructions. The requirements-dev.txt file has been modified to include additional dependencies for development. The responder/__main__.py file has been deleted, removing the entry point for the application. Lastly, the setup.py file has seen significant updates to its dependency list, package description, and classifiers, reflecting changes in project requirements and metadata.

Changes

File Change Summary
README.md Updated badge links and installation instructions; improved clarity in textual content.
requirements-dev.txt Changed editable installation from -e . to -e .[graphql,test] for additional dependencies.
responder/main.py Deleted file; removed entry point that imported and executed the main function.
setup.py Updated install_requires dependencies; modified package description; added new classifiers; removed entry points.

Poem

🐇 In the garden of code, we hop with glee,
Badges shining bright, for all to see.
New paths for the brave, with dependencies galore,
A cleaner README, who could ask for more?
With each little change, our project takes flight,
Hooray for the updates, everything feels right! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

amotl
amotl commented Oct 24, 2024
View reviewed changes
setup.py
author_email="[email protected]",
url="https://github.com/kennethreitz/responder",
packages=find_packages(exclude=["tests"]),
entry_points={"console_scripts": ["responder=responder.cli:cli"]},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @kennethreitz. While I am removing this reference for now, it could be sweet to add it back later. Is the CLI a vaporware feature, or did you just forget to add it to the repository?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vaporware apparently

setup.py
include_package_data=True,
license="Apache 2.0",
classifiers=[
"Development Status :: 5 - Production/Stable",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's sane?

@amotl amotl changed the title This and that 2 This and that: 20241024-02 Oct 24, 2024
@amotl amotl marked this pull request as ready for review October 24, 2024 01:02
@amotl amotl requested a review from kennethreitz October 24, 2024 01:02
@kennethreitz kennethreitz merged commit 398ac33 into main Oct 24, 2024
12 checks passed
@kennethreitz kennethreitz deleted the this-and-that-2 branch October 24, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennethreitz kennethreitz Awaiting requested review from kennethreitz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amotl @kennethreitz