-
-
Notifications
You must be signed in to change notification settings - Fork 218
Python: Verify support for Python 3.13 #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes involve an update to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PackageManager
participant setup.py
User->>PackageManager: Request package installation
PackageManager->>setup.py: Check compatibility
setup.py-->>PackageManager: Return compatibility (includes Python 3.13)
PackageManager-->>User: Install package
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@amotl Yes, I already replaced API star on Responder before |
|
Thanks, @tabotkevin. Apparently, the ingredients of GH-480 have been reverted down the line, despite your PR appears to be have been merged correctly? |
|
@amotl i ended up reverting a whole series of changes to try to get the repo closer to the state it was when i stopped actively maintaining it. It's in a much better spot for me now — but we may need to replay a few PRs that are valuable. |
|
@tabotkevin: Your patch GH-480 has been converged into GH-543, and submitted again. |
1107f5d to
80eebd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
About
Python 3.13.0 has been released on Oct. 7, 2024. This PR intends to add CI verification.