Update __repr__() method models.py #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I chose this additional piece of code (which.. "makes an attempt to return a string that would yield an object with the same value when passed to eval()") because models and test_crud are important in order to have the testing phase of this application work correctly. In the testing phase it is important to have access to printable versions of objects to see and determine what they contain. It is important to be able to easily access what an object contains easily via printing so that at any point of the complex process of testing, the developer can refer to and “evaluate” any object in the correct way.
There was a problem hiding this comment.
Hey @consarnproject, Thanks for raising this pr.
Unfortunately, this PR doesn’t include any meaningful changes, typos and breaking links are supposed or just content changes are to be reported not fixed. You can do so on the specific two repositories that we provided. In the future, please ensure that a PR in this repo is raised only if you’ve made substantial updates or solved a particular issue. This helps keep the process efficient and organized.
This being a part of an assignment in api fellowship would be counted since you were supposed to create a pr but wont be merged since this is not that relevant of a change. I’m sure you understand, and I appreciate your cooperation on this. We will be closing this PR for now.
|
Thank you for your message Pratik.
Should I go ahead and create a new PR that is more meaningful or am I ok
thus far ?
Kindest,
Andrew
…On Fri, Jun 27, 2025 at 7:58 AM Pratik Mahalle ***@***.***> wrote:
***@***.**** commented on this pull request.
Hey @consarnproject <https://github.com/consarnproject>, Thanks for
raising this pr.
Unfortunately, this PR doesn’t include any meaningful changes, typos and
breaking links are supposed or just content changes are to be reported not
fixed. You can do so on the specific two repositories that we provided. In
the future, please ensure that a PR in this repo is raised only if you’ve
made substantial updates or solved a particular issue. This helps keep the
process efficient and organized.
This being a part of an assignment in api fellowship would be counted
since you were supposed to create a pr but wont be merged since this is not
that relevant of a change. I’m sure you understand, and I appreciate your
cooperation on this. We will be closing this PR for now.
—
Reply to this email directly, view it on GitHub
<#47 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A7RWKPXFJT3ZXEA47XZWJCD3FTMRHAVCNFSM6AAAAAB7SVSN3KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSNRUHA3TKNZRGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Yeah, go ahead @consarnproject |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I chose this additional piece of code (which.. "makes an attempt to return a string that would yield an object with the same value when passed to eval()") because models and test_crud are important in order to have the testing phase of this application work correctly. In the testing phase it is important to have access to printable versions of objects to see and determine what they contain. It is important to be able to easily access what an object contains easily via printing so that at any point of the complex process of testing, the developer can refer to and “evaluate” any object in the correct way.