Skip to content

fix: Add fastapi-app service to docker-compose.yml. #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maverickjit
Copy link

🛠️ Description

This PR fixes Issue #13 by adding the missing fastapi-app service to the docker-compose.yml file under the fastapi-postgres sample.

Previously, the FastAPI container was not defined in docker-compose.yml, which prevented keploy record from detecting the application for testing.

🔧 Changes Made

  • Added fastapi-app service to fastapi-postgres/docker-compose.yml
  • Defined build context, ports, and dependencies
  • Enabled keploy record to work as expected with FastAPI

✅ How I Tested

  • Ran docker-compose up to start both FastAPI and Postgres
  • Verified FastAPI runs on port 8000
  • Used keploy record -c "docker-compose up" --container-name fastapi-app to capture test cases successfully
  • Confirmed test and mock files are generated

📌 Related Issue

Fixes #13

Let me know if there are additional changes or test scenarios you'd like me to add. Happy to iterate!
Screenshot 2025-06-19 043156

@pratik-mahalle
Copy link

Hey @maverickjit, Thank you for raising the changes. Our team will review the changes soon before that please make sure to sign the DCO

Copy link

@pratik-mahalle pratik-mahalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maverickjit, The fast-app service is already added in the repo.
You can check that here https://github.com/keploy/samples-python/blob/main/fastapi-postgres/docker-compose.yml
I really appreciate your effort. For now, we are closing this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants