Update references of jax_layout.Layout to jax_layout.Format. #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reflects an upstream change in JAX.
|
We need to first update jax_tpu_embedding and release a dev version for the changes to be picked up. |
hertschuh
reviewed
Jun 19, 2025
| @@ -8,7 +8,7 @@ torch>=2.1.0 | |||
| # Jax with cuda support. | |||
| # Keep same version as Keras repo. | |||
| --find-links https://storage.googleapis.com/jax-releases/jax_cuda_releases.html | |||
| jax[cuda12_pip]==0.6.0 | |||
| jax[cuda12_pip]==0.6.2 | |||
There was a problem hiding this comment.
How is this even working?
https://github.com/jax-ml/jax/blob/008522175ec75f4c2d70f6a6ea56e0d2da9771ed/CHANGELOG.md?plain=1#L69
There was a problem hiding this comment.
Interesting. Maybe it's not working? I didn't actually try this.
There was a problem hiding this comment.
Yeah, it's never been used I believe, so we wouldn't know if it's broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reflects an upstream change in JAX.