Only read queue when required #156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pull Request Title: Only Read Queue When Required
Motivation and Improvement
The primary motivation behind this pull request is to optimize the handling of live stream data by only reading from the queue when it is necessary. This change addresses unnecessary queue reads and improves the performance and efficiency of the live stream processing. The specific improvements are as follows:
Performance Optimization: By avoiding unnecessary reads from the queue when there are no active live stream requests, we reduce the computational overhead and improve the overall performance of the system.
Resource Utilization: This change ensures that resources are utilized more efficiently by only processing data when there is an active request, which can lead to reduced CPU and memory usage.
Code Cleanliness: The changes also include resetting the image object after processing, which helps in managing memory more effectively and prevents potential memory leaks.
Summary of Changes
HandleLiveStreamSDfunction to check the time since the last live stream request before reading from the queue.livestreamCursor.ReadPacket()and subsequent packet validation inside the condition that checks for active live stream requests.imageobject after processing, ensuring memory is managed properly.imagepackage to facilitate the image reset functionality.By implementing these changes, we ensure that the system is more responsive and efficient, leading to better performance and resource management.