hotfix/v3.5.6 #218
hotfix/v3.5.6 #218
Conversation
…ing device connection logic
There was a problem hiding this comment.
Pull Request Overview
This is a hotfix release (v3.5.6) that removes ONVIF event handling functionality and simplifies the ONVIF library integration by downgrading from v1.0.0 to v0.0.7.
- Commented out all ONVIF event-related code including digital input/output handling and relay triggering
- Simplified ONVIF device connection by removing capabilities parameter from ConnectToOnvifDevice function
- Updated ONVIF library dependency from v1.0.0 to v0.0.7 with corresponding code adjustments
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| machinery/src/routers/mqtt/main.go | Comments out HandleTriggerRelay function entirely |
| machinery/src/routers/http/methods.go | Removes unused log import and comments out digital input/output HTTP handlers |
| machinery/src/onvif/main.go | Major refactor removing event handling, simplifying device connection, and updating to older ONVIF library API |
| machinery/src/cloud/Cloud.go | Comments out ONVIF event subscription code in heartbeat handling |
| machinery/main.go | Comments out ONVIF device discovery functionality |
| machinery/go.mod | Downgrades kerberos-io/onvif from v1.0.0 to v0.0.7 and removes related dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if configurations.PTZConfiguration.DefaultAbsolutePantTiltPositionSpace != "" { | ||
| functions = append(functions, "AbsolutePanTiltMove") | ||
| canPanTilt = true | ||
| } | ||
| if configurations.PTZConfiguration[0].DefaultAbsoluteZoomPositionSpace != nil { | ||
| if configurations.PTZConfiguration.DefaultAbsoluteZoomPositionSpace != "" { | ||
| functions = append(functions, "AbsoluteZoomMove") | ||
| canZoom = true | ||
| } | ||
| if configurations.PTZConfiguration[0].DefaultRelativePanTiltTranslationSpace != nil { | ||
| if configurations.PTZConfiguration.DefaultRelativePanTiltTranslationSpace != "" { | ||
| functions = append(functions, "RelativePanTiltMove") | ||
| canPanTilt = true | ||
| } | ||
| if configurations.PTZConfiguration[0].DefaultRelativeZoomTranslationSpace != nil { | ||
| if configurations.PTZConfiguration.DefaultRelativeZoomTranslationSpace != "" { | ||
| functions = append(functions, "RelativeZoomMove") | ||
| canZoom = true | ||
| } | ||
| if configurations.PTZConfiguration[0].DefaultContinuousPanTiltVelocitySpace != nil { | ||
| if configurations.PTZConfiguration.DefaultContinuousPanTiltVelocitySpace != "" { | ||
| functions = append(functions, "ContinuousPanTiltMove") | ||
| canPanTilt = true | ||
| } | ||
| if configurations.PTZConfiguration[0].DefaultContinuousZoomVelocitySpace != nil { | ||
| if configurations.PTZConfiguration.DefaultContinuousZoomVelocitySpace != "" { | ||
| functions = append(functions, "ContinuousZoomMove") | ||
| canZoom = true | ||
| } | ||
| if configurations.PTZConfiguration[0].DefaultPTZSpeed != nil { | ||
| if configurations.PTZConfiguration.DefaultPTZSpeed != nil { | ||
| functions = append(functions, "PTZSpeed") | ||
| } | ||
| if configurations.PTZConfiguration[0].DefaultPTZTimeout != nil { | ||
| if configurations.PTZConfiguration.DefaultPTZTimeout != "" { |
There was a problem hiding this comment.
Accessing PTZConfiguration as a single object instead of an array. Based on the ONVIF library structure, this should likely be configurations.PTZConfiguration[0].DefaultAbsolutePantTiltPositionSpace to access the first configuration.
Copilot uses AI. Check for mistakes.
| Space: configuration.PTZConfiguration.DefaultAbsolutePantTiltPositionSpace, | ||
| } | ||
|
|
||
| absoluteZoomVector := xsdonvif.Vector1D{ | ||
| absoluteZoomVector := xsd.Vector1D{ | ||
| X: zoom, | ||
| Space: configuration.PTZConfiguration[0].DefaultAbsoluteZoomPositionSpace, | ||
| Space: configuration.PTZConfiguration.DefaultAbsoluteZoomPositionSpace, |
There was a problem hiding this comment.
Same issue as above - accessing PTZConfiguration as a single object instead of an array element. This should be configuration.PTZConfiguration[0].DefaultAbsolutePantTiltPositionSpace.
Copilot uses AI. Check for mistakes.
| PanTilt: absolutePantiltVector, | ||
| Zoom: absoluteZoomVector, |
There was a problem hiding this comment.
The PTZVector struct expects pointer fields based on the original code structure. These should be PanTilt: &absolutePantiltVector and Zoom: &absoluteZoomVector.
| PanTilt: absolutePantiltVector, | |
| Zoom: absoluteZoomVector, | |
| PanTilt: &absolutePantiltVector, | |
| Zoom: &absoluteZoomVector, |
Copilot uses AI. Check for mistakes.
| _, err := device.CallMethod(ptz.ContinuousMove{ | ||
| ProfileToken: &token, | ||
| Velocity: xsdonvif.PTZSpeedZoom{ | ||
| ProfileToken: token, |
There was a problem hiding this comment.
The ProfileToken field expects a pointer to the token. This should be ProfileToken: &token.
| ProfileToken: token, | |
| ProfileToken: &token, |
Copilot uses AI. Check for mistakes.
1 participant
Description
Pull Request: hotfix/v3.5.6
Motivation
The primary motivation for this hotfix is to address compatibility and stability issues by downgrading the
github.com/kerberos-io/onvifdependency from versionv1.0.0tov0.0.7. The newer version of this dependency introduced breaking changes that affected the functionality of our ONVIF integration. Additionally, several unused dependencies have been removed to streamline the project and reduce potential maintenance overhead.Why It Improves the Project
github.com/kerberos-io/onviftov0.0.7ensures that our project remains stable and compatible with the existing codebase, preventing runtime errors and unexpected behavior related to ONVIF device interactions.github.com/clbanning/mxj/v2,github.com/icholy/digest, andgithub.com/juju/errorsreduces the project's complexity and potential security vulnerabilities, making the codebase easier to maintain.go.modandgo.sumfiles by removing obsolete dependencies helps in maintaining a clean and manageable project structure.This hotfix ensures that the project remains robust and maintainable, addressing immediate issues while setting a foundation for future enhancements.