Skip to content

Add validations to groups form #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add validations to groups form #39

wants to merge 3 commits into from

Conversation

thestrabusiness
Copy link

@thestrabusiness thestrabusiness commented Jun 9, 2022 •
edited
Loading

Address #32

@thestrabusiness thestrabusiness force-pushed the anthony/groups-validations branch from 75ad892 to 6721aa5 Compare June 10, 2022 16:33
@thestrabusiness thestrabusiness marked this pull request as ready for review June 10, 2022 16:33
@thestrabusiness thestrabusiness changed the title WIP: Add validations to groups form Add validations to groups form Jun 10, 2022
simonkernel
simonkernel suggested changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@simonkernel simonkernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thestrabusiness,

Thanks for working on this and apologizes for just getting to this now!

We have @mgorkove with PR #40 in flight right now as well which will impact the Form component and validation.

I like the general approach and we're sort of re-implementing validation and alerts in each app. It would be great to keep things generic where possible.

Not saying we have to be able to use right away, just if there's a path to eventually extract it so to just keep it in mind.

I'd say let's hold off until the autocomplete PR lands and apologies for the cross-over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@simonkernel simonkernel simonkernel requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thestrabusiness @simonkernel