Skip to content

Fixed race condition #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed race condition #33

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6298a1
Fix race condition and relaxed presence detect ping timings
cactrot Sep 18, 2015
9b5ed3e
Create index.html
cactrot Sep 18, 2015
83959ec
Delete index.html
cactrot Sep 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions arduino_extension.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
queryFirmware();
pinging = true;
}
}, 100);
}, 2000);
}

function hasCapability(pin, mode) {
Expand Down Expand Up @@ -180,7 +180,11 @@
case CAPABILITY_RESPONSE:
for (var i = 1, pin = 0; pin < MAX_PINS; pin++) {
while (storedInputData[i++] != 0x7F) {
pinModes[storedInputData[i-1]].push(pin);
// This helped reduce error over a noisy wireless serial connection
if ( storedInputData[i-1] <= MAX_PINS )
{
pinModes[storedInputData[i-1]].push(pin);
}
i++; //Skip mode resolution
}
if (i == sysexBytesRead) break;
Expand Down Expand Up @@ -502,11 +506,13 @@
device = potentialDevices.shift();
if (!device) return;

device.open({ stopBits: 0, bitRate: 57600, ctsFlowControl: 0 });
// Moved set_receive_handler to the ready callback for open to fix a race condition.
console.log('Attempting connection with ' + device.id);
device.set_receive_handler(function(data) {
var inputData = new Uint8Array(data);
processInput(inputData);
device.open({ stopBits: 0, bitRate: 57600, ctsFlowControl: 0 }, function() {
device.set_receive_handler(function(data) {
var inputData = new Uint8Array(data);
processInput(inputData);
});
});

poller = setInterval(function() {
Expand Down