Skip to content

Add salt to password hashing and improve security #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add salt to password hashing and improve security #57

wants to merge 2 commits into from

Conversation

Anshv784
Copy link
Contributor

@Anshv784 Anshv784 commented Sep 7, 2025

Fixes #49

Problem:

  • Passwords were hashed without an explicit salt, making them weaker.

Solution:

  • Added bcrypt salt (10 rounds) to the signUp function.
  • Updated user.save() to use await for proper error handling.
  • Password verification remains secure with compareSync.

@vercel Vercel
Copy link

vercel bot commented Sep 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
blog-app-using-mern-stack Error Error Sep 7, 2025 5:02pm

khushi2706
khushi2706 reviewed Sep 15, 2025
View reviewed changes
Copy link
Owner

@khushi2706 khushi2706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khushi2706 khushi2706 khushi2706 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lack of salt in the password generation
2 participants
@Anshv784 @khushi2706