chore(deps): update dependency @types/jest to v30 #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
requested review from
chihiro-adachi and
shabaraba
and removed request for
a team
renovate
bot
force-pushed
the
renovate/jest-30.x
branch
from
7004c8f to
f24b975
Compare
… to 30.0.0 - Fix deprecated Jest matcher aliases and error comparisons - All tests, build, and lint checks pass
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
| @@ -55,6 +55,6 @@ describe("deleteRecords", () => { | |||
| apiClient.record.getAllRecordsWithId = jest.fn().mockResolvedValue([]); | |||
| return expect( | |||
| deleteByRecordNumber(apiClient, "1", [{ value: "appcode-1" }]), | |||
| ).rejects.toThrow(error); | |||
| ).rejects.toThrow("Failed to delete records"); | |||
There was a problem hiding this comment.
@shabaraba
ここだけに限らずなのですが、toThrowにわたす引数の変更って必要ありますでしょうか？
※エラーのオブジェクト渡すのはv30でも変更なさそうにみえたので。
https://jestjs.io/docs/expect#tothrowerror
There was a problem hiding this comment.
具体的なソースが見当たらないのでアレなんですが、どうやら30に上がるまでに、toThrow(error)としてもオブジェクト比較ではなく、error.messageで比較をする挙動に変わったようでした。
なので既存実装だと以下のような形でテストが落ちます。
Expected message: "Failed to delete records"
Received message and cause: "{\"cause\":\" Not exists record number. ID: appcode-1\\n\",\"detail\":\"\",\"message\":\"Failed to delete records\",\"name\":\"ValidatorError\"}"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^29.5.14->^30.0.0Configuration
📅 Schedule: Branch creation - "after 9pm,before 9am" in timezone Asia/Tokyo, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.