forked from ganadist/AndroidApiDemo
-
Notifications
You must be signed in to change notification settings - Fork 3
View/List #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
snowflake-1117
wants to merge
56
commits into
kotlin-korea:next
Choose a base branch
from
snowflake-1117:next
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
View/List #1
Changes from 6 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
62c2ee6
Add component to .gitignore file
snowflake-1117 8d1c82b
Convert Animation1 Java file into Kotiln file
snowflake-1117 42805f0
Use android:inputType instead of android:password
snowflake-1117 bda3d38
Convert Animation2 Java file into Kotlin file
snowflake-1117 e18c428
Convert Animation3 Java file into Kotiln file
snowflake-1117 7354a7e
Remove unnecessary variable declaration using let
snowflake-1117 f1a413d
Move variables declaration location for readability
snowflake-1117 a85e84c
Remove unnecessary variable declaration using let
snowflake-1117 96e8577
Initialize variable a using apply
snowflake-1117 979763c
Variable names were replaced by meaningful names
snowflake-1117 cf57be4
extensions 플러그인 추가
snowflake-1117 ddf3b00
extensions 적용
snowflake-1117 3c23056
AutoComplete1~3 코틀린으로 변환
snowflake-1117 01beed7
불필요한 run 적용 제거
snowflake-1117 7f7f3a1
when 내부 pair 처리를 위해 arrayOf 사용
snowflake-1117 946312a
animation.interpolator에 when의 결과 값을 할당해 코드를 간결하게 함
snowflake-1117 8a75e66
alpha9 업데이트 적용
snowflake-1117 35d6972
AutoComplete6 코틀린으로 변환
snowflake-1117 8cbc27e
AutoComplete4 코틀린으로 변환
snowflake-1117 d5f167f
READ_CONTACTS 권한 permission 기능 구현
snowflake-1117 0976384
자동완성이 되지 않는 버그 수정
snowflake-1117 5cebd04
권한 허용 여부를 체크하는 checkPermission 함수 분리
snowflake-1117 7a333c5
코드 리팩토링
snowflake-1117 0e9192e
권한허용 함수 적용
snowflake-1117 455f740
Baseline 파일들 코틀린으로 변환
snowflake-1117 44dbe66
BaselineNaested 파일들 코틀린으로 변환
snowflake-1117 4f2fe65
자바파일 코틀린 파일로 변환
snowflake-1117 1a3786c
gradle 업데이트 적용
snowflake-1117 62f5b35
매니페스트 파일에 맞춰 minSdkVersion 23으로 변경
snowflake-1117 661b8d9
Revert "자바파일 코틀린 파일로 변환"
snowflake-1117 7d0d69d
다이얼로그 출력 문자열 리소스 파일로 이동 후 적용
snowflake-1117 68718ab
입력받는 문자열이 빈칸일 때, non-null로 추정되는 변수가 null인 예외 발생문제 해결
snowflake-1117 8875a26
buildToolsVersion 26.0.1 적용
snowflake-1117 3a276cf
연락처 Permission 체크를 위한 공통 클래스 생성
snowflake-1117 cafbc32
ContactPermission 클래스 적용
snowflake-1117 10d3ea7
gradle 업데이트
snowflake-1117 7d59dcf
List1 코틀린으로 변환
snowflake-1117 599362a
List2 코틀린으로 변환
snowflake-1117 d6175f4
lazy 사용해서 var -> val 변수로 전환
snowflake-1117 4fbd268
List3 코틀린으로 변환
snowflake-1117 acf9ddb
List4 코틀린으로 변환
snowflake-1117 0a15bbe
List5 코틀린으로 변환
snowflake-1117 bdcf79d
List6 코틀린으로 변환
snowflake-1117 bbf63ab
List7 코틀린으로 변환
snowflake-1117 50ed3dc
List8 코틀린으로 변환
snowflake-1117 b34cbe3
List8 getView 파라미터 convertView Nullable로 전환
snowflake-1117 67049c2
List9 코틀린으로 변환
snowflake-1117 8a05af5
List10 코틀린으로 변환
snowflake-1117 4a307ed
List11 코틀린으로 변환
snowflake-1117 da72941
List12 코틀린으로 변환
snowflake-1117 a6eb26a
List13 코틀린으로 변환
snowflake-1117 1cb8fb7
List14 코틀린으로 변환
snowflake-1117 e85416e
List15 코틀린으로 변환
snowflake-1117 1048766
List16 코틀린으로 변환
snowflake-1117 dd0c899
사용하지 않는 import 삭제
snowflake-1117 de7fa04
List17 코틀린으로 변환
snowflake-1117 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,11 +4,11 @@ apply plugin: 'kotlin-android-extensions' | |
|
||
android { | ||
compileSdkVersion 26 | ||
buildToolsVersion "26.0.0" | ||
buildToolsVersion '26.0.0' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 26.0.0의 버그가 수정된 |
||
|
||
defaultConfig { | ||
applicationId "com.example.android.apis" | ||
minSdkVersion 15 | ||
minSdkVersion 23 | ||
targetSdkVersion 26 | ||
versionCode 1 | ||
versionName "1.0" | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 0 additions & 36 deletions
36
mobile/src/main/java/com/example/android/apis/view/BaselineNested3.java
This file was deleted.
Oops, something went wrong.
35 changes: 35 additions & 0 deletions
35
mobile/src/main/java/com/example/android/apis/view/BaselineNested3.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
/* | ||
* Copyright (C) 2007 The Android Open Source Project | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.example.android.apis.view | ||
|
||
import com.example.android.apis.R | ||
|
||
import android.app.Activity | ||
import android.os.Bundle | ||
|
||
/** | ||
* Baseline alignment includes a [android.widget.LinearLayout] | ||
* within another [android.widget.LinearLayout]. | ||
*/ | ||
class BaselineNested3 : Activity() { | ||
|
||
override fun onCreate(savedInstanceState: Bundle?) { | ||
super.onCreate(savedInstanceState) | ||
|
||
setContentView(R.layout.baseline_nested_3) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 빠른 도입