Introduce enhanced ecommerce properties #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoebanath
reviewed
Jan 12, 2017
| @@ -406,6 +406,55 @@ | |||
| 'description' => 'Currency code', | |||
| 'location' => 'postField', | |||
| ), | |||
| // enchanced ecommerce | |||
There was a problem hiding this comment.
Typo :)
Should be "Enhanced Ecommerce"
|
Thanks :)! PR updated. |
|
Would you be willing to merge @amoebanath? Thanks. |
|
Oh I don't have permission, sorry! |
|
@krizon Do you have any objection against this PR? Or is there simply not enough time to maintain this repo? I'd be willing to help. I.e. by cutting the release and updating changelog and such. |
jordikroon
reviewed
Mar 7, 2017
| @@ -406,7 +406,7 @@ | |||
| 'description' => 'Currency code', | |||
| 'location' => 'postField', | |||
| ), | |||
| // enchanced ecommerce | |||
| // enhanced ecommerce | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented by Google in https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters
Used this code in production already and it is pushing to Analytics like expected!