Rust 2024 let-chains to simplify wait Conditions #1792
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
started out as a PR to try out let-chains, but found that it solves most of the the ergonomic problem with the wait API that I tried to solve earlier in #1498
it's not quite as elegant as #1498, but it also doesn't come with any of the problems and is non-breaking.
Unfortunately it does require rust2024 on rustfmt which means it does require a lot of incidental changes.
The first commit is the human generated part, the second is from cargo fmt (third to get CI to accept it).
It's a little early for this because it requires Rust 1.88 (current latest), and we should wait a version or two before making a requirement.
But if the general setup (outlined in the first commit) is acceptable, I'll rebase at 1.90.