Switch to PAT_TOKEN for git branch push #4086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Min Jin <[email protected]>
k8s-ci-robot
added
approved
|
Why is this permission required for the checkout step? |
|
@brendandburns The checkout step is where we initialize the identity/permission for the follow-up git commands including
|
|
/lgtm Thanks for the link to the docs. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The github action lost permission to push branch after maven release even though the maven release was successful. Looks like the permission got tighten again recently because we didn't have this error when publishing 24.0.0.. This PR proposes to use PAT_TOKEN which has the repo write permission to automate the version release process.
We need to choose a poison between having a long manual release process and the risk of increasing the permission for github action..
/cc @brendandburns