Skip to content

Conversation

thefirstofthe300
Copy link
Contributor

@thefirstofthe300 thefirstofthe300 commented Oct 3, 2025

Change description

The current arm64 implementation for Flatcar is half-baked, mainly due to the containerd and runc binaries being downloaded for the wrong architecture.

This PR makes an attempt to better automatically detect the OS and architecture of the machine during the installation of those two binaries.

I have tested both the amd64 and arm64 installation paths in AWS. I don't have access at work to any other cloud provider so I haven't been able to test elsewhere.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 3, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @thefirstofthe300. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign averagemarcus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 3, 2025
@thefirstofthe300 thefirstofthe300 force-pushed the thefirstofthe300/support-arm64-containerd branch from f8e4515 to 7112804 Compare October 3, 2025 00:56
@mboersma
Copy link
Contributor

mboersma commented Oct 6, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2025
@thefirstofthe300 thefirstofthe300 force-pushed the thefirstofthe300/support-arm64-containerd branch from 00c1bf5 to 77b3163 Compare October 7, 2025 00:46
@thefirstofthe300
Copy link
Contributor Author

/retest

1 similar comment
@thefirstofthe300
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants