-
Notifications
You must be signed in to change notification settings - Fork 448
fix: Ensure correct architecture containerd/runc is downloaded #1859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: Ensure correct architecture containerd/runc is downloaded #1859
Conversation
Hi @thefirstofthe300. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f8e4515
to
7112804
Compare
/ok-to-test |
00c1bf5
to
77b3163
Compare
/retest |
1 similar comment
/retest |
Change description
The current arm64 implementation for Flatcar is half-baked, mainly due to the containerd and runc binaries being downloaded for the wrong architecture.
This PR makes an attempt to better automatically detect the OS and architecture of the machine during the installation of those two binaries.
I have tested both the amd64 and arm64 installation paths in AWS. I don't have access at work to any other cloud provider so I haven't been able to test elsewhere.