Skip to content

Conversation

chansuke
Copy link
Member

@chansuke chansuke commented Aug 19, 2025

Closes #5653

replace deprecated commonLabels with labels

the following files were intentionally unchanged:

  • examples/transformerconfigs/README.md // the documentation of transformer
  • site/content/ // API reference document
  • examples/alphaTestExamples/helloapp.md // alpha test example
  • examples/zh/ // Chinese translation (out of scope)
  • test files that needed for backwards compatibility testing

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chansuke
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 19, 2025
@k8s-ci-robot
Copy link
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chansuke chansuke force-pushed the fix/remove-deprecated-commonlabels branch from 7602368 to c0b26cc Compare August 19, 2025 09:46
@chansuke chansuke marked this pull request as ready for review August 19, 2025 11:02
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2025
@k8s-ci-robot k8s-ci-robot requested a review from koba1t August 19, 2025 11:02
@sarab97
Copy link
Member

sarab97 commented Aug 19, 2025

/lgtm

@k8s-ci-robot
Copy link
Contributor

@sarab97: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@koba1t
Copy link
Member

koba1t commented Aug 21, 2025

Hi @chansuke

Thanks for your help!
I added one comment, please check that.

By the way, I think we're still using deprecated fields in our official docs.
Could you fix those too?
https://github.com/kubernetes-sigs/cli-experimental/tree/master/site

@chansuke
Copy link
Member Author

@koba1t
Thank you so much for your review!! Yes, I will handle this too:)

@chansuke chansuke requested a review from koba1t August 24, 2025 01:31
@koba1t koba1t added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 24, 2025
@chansuke chansuke requested a review from koba1t August 25, 2025 14:45
@stormqueen1990
Copy link
Member

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from stormqueen1990 September 14, 2025 21:03
Copy link
Member

@koba1t koba1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!
I've added a few more comments. Please check them.

variant: staging
org: acmeCorporation
labels:
- includeSelectors: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like includeSelectors was removed from examples/helloWorld/kustomization.yaml.
Do you have any reason to still remain?

variant: production
org: acmeCorporation
labels:
- includeSelectors: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

commonLabels:
foo: bar
labels:
- includeSelectors: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.


commonLabels:
foo: bar
labels:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example modifies the behavior of commonLabels in the transformer configuration.
If you modify this section, also update the README.md to instruct users to configure the labels transformer accordingly.

If you don't know how to change the contents of this section, it's fine to keep it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kustomize example in README uses deprecated commonLabels
5 participants