-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: remove deprecated commonLabels
#5965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: remove deprecated commonLabels
#5965
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chansuke The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7602368
to
c0b26cc
Compare
/lgtm |
@sarab97: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @chansuke Thanks for your help! By the way, I think we're still using deprecated fields in our official docs. |
@koba1t |
d320ac3
to
0424a19
Compare
/uncc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
I've added a few more comments. Please check them.
variant: staging | ||
org: acmeCorporation | ||
labels: | ||
- includeSelectors: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like includeSelectors
was removed from examples/helloWorld/kustomization.yaml.
Do you have any reason to still remain?
variant: production | ||
org: acmeCorporation | ||
labels: | ||
- includeSelectors: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
commonLabels: | ||
foo: bar | ||
labels: | ||
- includeSelectors: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
|
||
commonLabels: | ||
foo: bar | ||
labels: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example modifies the behavior of commonLabels
in the transformer configuration.
If you modify this section, also update the README.md to instruct users to configure the labels
transformer accordingly.
If you don't know how to change the contents of this section, it's fine to keep it as is.
Closes #5653
replace deprecated
commonLabels
withlabels
the following files were intentionally unchanged: