Skip to content

apis: add ServiceImport condition #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

apis: add ServiceImport condition #113

wants to merge 1 commit into from
+62 −0

Conversation

MrFreezeex
Copy link
Member

@MrFreezeex MrFreezeex commented Jun 27, 2025 •
edited
Loading

TODO:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2025
@k8s-ci-robot k8s-ci-robot requested review from JeremyOT and skitt June 27, 2025 16:38
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrFreezeex
Once this PR has been reviewed and has the lgtm label, please assign pmorie for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 27, 2025
@MrFreezeex MrFreezeex force-pushed the svcimport-conditions branch 3 times, most recently from aa87408 to c9911b7 Compare June 27, 2025 19:48
MrFreezeex
MrFreezeex commented Jun 27, 2025
View reviewed changes
@MrFreezeex
Copy link
Member Author

/cc @tpantelis @mikemorris

@MrFreezeex
Copy link
Member Author

/test pull-mcs-api-e2e

@mikemorris mikemorris mentioned this pull request Jun 27, 2025
Open
2 tasks
@MrFreezeex MrFreezeex force-pushed the svcimport-conditions branch 2 times, most recently from 042a670 to 00c70da Compare June 27, 2025 21:46
mikemorris
mikemorris reviewed Jun 27, 2025
View reviewed changes
Copy link

@mikemorris mikemorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes a lot of sense! Minor notes but mostly LGTM.

@MrFreezeex MrFreezeex force-pushed the svcimport-conditions branch 2 times, most recently from bb4ed35 to 2651927 Compare June 27, 2025 22:14
@mikemorris
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2025
@MrFreezeex MrFreezeex force-pushed the svcimport-conditions branch from 2651927 to 557afe5 Compare June 30, 2025 08:55
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2025
@MrFreezeex MrFreezeex force-pushed the svcimport-conditions branch from 557afe5 to 2d20397 Compare June 30, 2025 08:57
@MrFreezeex
apis: add ServiceImport condition
49f3cf7 
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
@MrFreezeex MrFreezeex force-pushed the svcimport-conditions branch from 2d20397 to 49f3cf7 Compare June 30, 2025 11:41
This was referenced Jul 1, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemorris mikemorris mikemorris left review comments

@JeremyOT JeremyOT Awaiting requested review from JeremyOT

@skitt skitt Awaiting requested review from skitt

@tpantelis tpantelis Awaiting requested review from tpantelis

Assignees

@mikemorris mikemorris

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrFreezeex @k8s-ci-robot @mikemorris